Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render email addresses as such if followed by punctuation (#27987) #27991

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Render email addresses as such if followed by punctuation (#27987) #27991

merged 1 commit into from
Nov 11, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #27987 by @yardenshoham

Added the following characters to the regular expression for the email:

  • ,
  • ;
  • ?
  • !

Also added a test case.

Before

image

After

image

@yardenshoham @GiteaBot
Render email addresses as such if followed by punctuation (go-gitea#2…
336d274 
…7987)

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes go-gitea#27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added topic/content-rendering Changes how certain filetypes are displayed type/enhancement An improvement of existing functionality labels Nov 11, 2023
@GiteaBot GiteaBot added this to the 1.20.6 milestone Nov 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2023
@lunny lunny merged commit dfd960f into go-gitea:release/v1.20 Nov 11, 2023
21 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

@delvh delvh Awaiting requested review from delvh

@silverwind silverwind Awaiting requested review from silverwind

Assignees

@yardenshoham yardenshoham

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/content-rendering Changes how certain filetypes are displayed type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.6
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @6543 @yardenshoham