-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix system config cache expiration timing #28072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
backport/v1.21
This PR should be backported to Gitea 1.21
labels
Nov 15, 2023
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 15, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 15, 2023
Closed
lunny
approved these changes
Nov 15, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 15, 2023
Since the first read lock is only used for
to simplify code. I guess it's not very harmful to the performance? |
I think the "read lock" is still good to have. To simplify it, it could be like the last commit. |
wxiaoguang
force-pushed
the
fix-setting-cache
branch
from
November 16, 2023 04:38
c2d73ff
to
cbe1813
Compare
lng2020
approved these changes
Nov 16, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 16, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Nov 16, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 16, 2023
To avoid unnecessary database access, the `cacheTime` should always be set if the revision has been checked. Fix go-gitea#28057
GiteaBot
added
backport/done
All backports for this PR have been created
and removed
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Nov 16, 2023
wxiaoguang
added a commit
that referenced
this pull request
Nov 16, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 17, 2023
* giteaofficial/main: Fix incorrect pgsql conn builder behavior (go-gitea#28085) Fix system config cache expiration timing (go-gitea#28072)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
To avoid unnecessary database access, the `cacheTime` should always be set if the revision has been checked. Fix go-gitea#28057
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid unnecessary database access, the
cacheTime
should always be set if the revision has been checked.Fix #28057