Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swagger title #28164

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix swagger title #28164

merged 2 commits into from
Nov 22, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Nov 22, 2023

image
Don't know why there's a . behind. 🤔

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 22, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Nov 22, 2023
@denyskon denyskon added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 22, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 22, 2023
@wxiaoguang
Copy link
Contributor

I guess it's not the right file to change.

Have you tried make generate-swagger?

@denyskon
Copy link
Member

However what'd even be the correct path to fix if the file is being generated?

lunny
lunny requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per #28164 (comment)

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 22, 2023 •
edited
Loading

However what'd even be the correct path to fix if the file is being generated?

I don't know too. I'm trying to figure out it.

@yp05327
Copy link
Contributor Author

yp05327 commented Nov 22, 2023 •
edited
Loading

@lunny @denyskon
Done in 1caa6c9

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Nov 22, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 22, 2023
@lunny lunny added this to the 1.22.0 milestone Nov 22, 2023
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Nov 22, 2023
@lunny lunny enabled auto-merge (squash) November 22, 2023 07:45
@lunny lunny merged commit 4d0eba8 into go-gitea:main Nov 22, 2023
24 checks passed
@GiteaBot GiteaBot mentioned this pull request Nov 22, 2023
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 22, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 22, 2023
@yp05327 @GiteaBot
Fix swagger title (go-gitea#28164)
de06ff1 
![image](https://github.com/go-gitea/gitea/assets/18380374/380859b2-a643-42fd-b53e-78c93c05c826)
Don't know why there's a `.` behind. 🤔
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 22, 2023
lunny pushed a commit that referenced this pull request Nov 22, 2023
@GiteaBot @yp05327
Fix swagger title (#28164) (#28167)
994ba35 
Backport #28164 by @yp05327


![image](https://github.com/go-gitea/gitea/assets/18380374/380859b2-a643-42fd-b53e-78c93c05c826)
Don't know why there's a `.` behind. 🤔

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 23, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
eaae23d 
* giteaofficial/main:
  Revert "Fix EOL handling in web editor" (go-gitea#28101)
  Fix swagger title (go-gitea#28164)
@yp05327 yp05327 deleted the fix-swagger-title branch November 23, 2023 23:16
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@yp05327 @fuxiaohei
Fix swagger title (go-gitea#28164)
b72f68c 
![image](https://github.com/go-gitea/gitea/assets/18380374/380859b2-a643-42fd-b53e-78c93c05c826)
Don't know why there's a `.` behind. 🤔
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yp05327 @wxiaoguang @denyskon @lunny @GiteaBot