Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail when API & web endpoints use unrelated ids #28212

Closed
wants to merge 16 commits into from
Closed

Fail when API & web endpoints use unrelated ids #28212

wants to merge 16 commits into from

Commits on Nov 25, 2023

  1. enforce reqRepoReader(unit.TypeIssues) GET /repos/{owner}/{repo}/issu… 

    …es/pinned

(cherry picked from commit 00fad97fc1b27db40a002c9ab3f709d04dc2cdd1)
(cherry picked from commit a8a0784e3f4cf24973af3c86f9245beee82a9026)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    9bd08c9 View commit details
    Browse the repository at this point in the history

  2. enforce reqRepoReader(unit.TypeIssues) POST /repos/{owner}/{repo}/issues 

    (cherry picked from commit d3db2fa8bc85e9d67f30854bba0a4c1e8b57b015)
(cherry picked from commit e95565a6ad82a1fa5d61f3e02a76f696fcdcbf03)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    3ff58e4 View commit details
    Browse the repository at this point in the history

  3. fix API usage of a PR index in place of issue index and vice versa 

    (cherry picked from commit 7b95266de083c8de0ff224530a9b69e82c52c344)
(cherry picked from commit 30f43dbcd47c80cc2dde2bb23e7f57e9bc7bfa61)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    df818bb View commit details
    Browse the repository at this point in the history

  4. fix PATCH /api/v1/repos/{owner}/{repo}/issues/comments/{id} 

    (cherry picked from commit 51c280e877765efe721e607aa95bcbb5aef364e0)
(cherry picked from commit 383b4333cf7aa1165e20d8a9bd2c07e3212b9da8)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    81e348d View commit details
    Browse the repository at this point in the history

  5. fix {DELETE,POST} /repos/{owner}/{repo}/issues/comments/{id}/reactions 

    (cherry picked from commit f499075c53752f983c6e4f8af17c449926ba94d9)
(cherry picked from commit df1a01507f61790bb89de1f2d4cce474fc3a544e)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    0f1204d View commit details
    Browse the repository at this point in the history

  6. fix GET /repos/{owner}/{repo}/issues/comments/{id}/reactions 

    (cherry picked from commit a146e3d0f9ff8ac1aee4be8a3632c76b35fc3482)
(cherry picked from commit 2f6dc175aab7541581401b1005b23b054906ee77)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    594ce97 View commit details
    Browse the repository at this point in the history

  7. fix DELETE /api/v1/repos/{owner}/{repo}/issues/comments/{id} 

    (cherry picked from commit 521eed2312f45bef7de28c9c03c04257862a453c)
(cherry picked from commit 7ef02b03d1fbebf5c1cbae5688381ff732d25391)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    f503719 View commit details
    Browse the repository at this point in the history

  8. fix POST /{owner}/{repo}/comments/{id}/delete 

    (cherry picked from commit 1b57d8493882d9d659164acd3b4a5a99c769d8ed)
(cherry picked from commit ffe70563fed45d384e0a20a1a4be76114a515075)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    1b1c36f View commit details
    Browse the repository at this point in the history

  9. fix POST /{owner}/{repo}/comments/{id} 

    (cherry picked from commit 385a1f337462bec34ccc389d4efe21e3b2be8465)
(cherry picked from commit 6e45c8d1cb1e55f477dd8f6dc793a7146c9c6675)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    d1254d1 View commit details
    Browse the repository at this point in the history

  10. fix POST /{owner}/{repo}/comments/{id}/reactions/{action} 

    (cherry picked from commit 21d4556cbeb9d0f825398114ba3a4816f331315b)
(cherry picked from commit 3cd467f82f570e5a2c3075bdc2ec0c17a998ebb1)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    9a7bb55 View commit details
    Browse the repository at this point in the history

  11. fix GET /{owner}/{repo}/comments/{id}/attachments 

    (cherry picked from commit aed193ef9f5d59aed12cfd7518765d5598c7999f)
(cherry picked from commit 12c8414d84c9c15b066652dbae04f48d02882494)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    8606efd View commit details
    Browse the repository at this point in the history

  12. fix POST /{username}/{reponame}/{type:issues|pulls}/{index}/content-h… 

    …istory/soft-delete

(cherry picked from commit a11d82a42729eba02032310f7778a9197f4f8ead)
(cherry picked from commit 020e2983bb1229f27538872842c955c8c3992461)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    485d48c View commit details
    Browse the repository at this point in the history

  13. fix GET /{username}/{reponame}/{type:issues|pulls}/{index}/content-hi… 

    …story/detail

(cherry picked from commit 0853dec293dd632a03948f66af69e75dd582a92d)
(cherry picked from commit 8078a3d400e719e95277a9fcc452b4101e40002a)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    352b68c View commit details
    Browse the repository at this point in the history

  14. fix POST /{username}/{reponame}/{tags,release}/delete 

    (cherry picked from commit a6d2ad6310f754952998fd73118da9f91c563145)
(cherry picked from commit 921256ccb15c1cc31da25196235e94c6ab1bb9e3)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    ef1e394 View commit details
    Browse the repository at this point in the history

  15. fix GET /api/v1/repos/{owner}/{repo}/keys/{id} 

    (cherry picked from commit 768238d9f9982e99ad4cbf3942d2d2db5126a150)

Conflicts:
	routers/api/v1/repo/key.go
	trivial context conflict
(cherry picked from commit a6627d18257fbc601e459ff4a6a6a0c1da1eabb5)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    ba4c12d View commit details
    Browse the repository at this point in the history

  16. fix POST /{username}/{reponame}/{type:issues|pulls}/move_pin 

    (cherry picked from commit 7eda733ed6a22c08a85fdc90deec0c440427cef7)
(cherry picked from commit 2f9ba33d6dbece0836de7ddabc335a61e52c268c)
    @earl-warren
    Loïc Dachary authored and earl-warren committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    e56ce32 View commit details
    Browse the repository at this point in the history