Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment permissions (#28213) #28216

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Fix comment permissions (#28213) #28216

merged 2 commits into from
Nov 25, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 25, 2023

backport #28213

This PR will fix some missed checks for private repositories' data on web routes and API routes.

@lunny
Fix comment permissions (go-gitea#28213)
3fde94d 
This PR will fix some missed checks for private repositories' data on
web routes and API routes.
@lunny lunny added the type/bug label Nov 25, 2023
@lunny lunny added this to the 1.21.1 milestone Nov 25, 2023
@lunny lunny requested review from wxiaoguang and delvh November 25, 2023 17:36
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 25, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Nov 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2023
@lafriks lafriks enabled auto-merge (squash) November 25, 2023 23:23
@lafriks lafriks disabled auto-merge November 25, 2023 23:23
@lafriks lafriks enabled auto-merge (squash) November 25, 2023 23:24
@lafriks lafriks merged commit bc3d8bf into go-gitea:release/v1.21 Nov 25, 2023
26 checks passed
@lunny lunny deleted the lunny/fix_permissions branch November 26, 2023 00:36
@lunny lunny added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Nov 26, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lafriks lafriks lafriks approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.21.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @lafriks @delvh @GiteaBot