Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs problems in 1.19 #28236

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix docs problems in 1.19 #28236

merged 1 commit into from
Nov 27, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Nov 27, 2023

Follow #28191

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2023
@GiteaBot
Copy link
Contributor

@yp05327 I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵

@yp05327 yp05327 changed the base branch from main to release/v1.19 November 27, 2023 02:39
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 27, 2023

@GiteaBot
Sorry. Forgot changing base branch. 😝

@yp05327 yp05327 requested a review from lng2020 November 27, 2023 02:41
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 27, 2023

I don't know whether logging-config.zh-cn.md matches logging-documentation.en-us.md in this version

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2023
@techknowlogick techknowlogick merged commit 3d7f636 into go-gitea:release/v1.19 Nov 27, 2023
2 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 27, 2023
@yp05327 yp05327 deleted the fix-docs-in-1.19 branch November 28, 2023 02:47
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

@lng2020 lng2020 Awaiting requested review from lng2020

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @GiteaBot @lunny @techknowlogick