Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show workflow names for other branchs on action list sidebar also #28333

Closed

Conversation

a1012112796
Copy link
Member

quick fix #28332, do it by a quick check in ActionRun table.

  • TODO: looks need more jobs about workflow lables check in future.

quick fix go-gitea#28332, do it by a quick check in
`ActionRun` table.

TODO: looks need more jobs about workflow
lables check in future.

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2023
Signed-off-by: a1012112796 <1012112796@qq.com>
@yp05327
Copy link
Contributor

yp05327 commented Dec 4, 2023

I don't think this can be simply fixed by checking file name,
as these workflows with same file name may have different contents.

ps: GitHub also have some bugs here:
image
The correct name is schema-test, but it shows the recently run workflow's name above.
image
image

https://github.com/yp05327/test2/actions

@a1012112796
Copy link
Member Author

I don't think this can be simply fixed by checking file name, as these workflows with same file name may have different contents.

ps: GitHub also have some bugs here: image The correct name is schema-test, but it shows the recently run workflow's name above. image image

https://github.com/yp05327/test2/actions

but now we don't show the content of workflow file, and don't check labels ether, just show a link; so I thnk this changes is enough now.

@a1012112796
Copy link
Member Author

I don't think this can be simply fixed by checking file name, as these workflows with same file name may have different contents.

or looks you misunderstood the aim of this bug fix, just to show all workflow name links in sidebar, not consider about other things.

@a1012112796 a1012112796 changed the title show workflow names on other branchs also show workflow names for other branchs on action list sidebar also Dec 4, 2023
@a1012112796
Copy link
Member Author

a1012112796 commented Dec 4, 2023

in future, I'd like add a new table to record workflow lable status and update it on pushing to branch to enhancement this logic.

type WorkflowBranch struct {
	Branch string
	Labels []string
	ErrMsg string
}

type ActionWorkflow struct {
	ID      int64 `xorm:"pk autoincr"`
	RepoID  int64
	Name    string
	Branchs []*WorkflowBranch `xorm:"JSON TEXT"`
	ErrMsg  string            `json:"-"` // for ui logic
}

@yp05327
Copy link
Contributor

yp05327 commented Dec 5, 2023

or looks you misunderstood the aim of this bug fix, just to show all workflow name links in sidebar, not consider about other things.

The workflow content and runnable runner checking will be broken.
e.g. only the workflow in default branch will display no matching runner warning.
image

@a1012112796 a1012112796 closed this Dec 5, 2023
@a1012112796 a1012112796 deleted the zzc/dev/fix_action_list branch December 5, 2023 08:53
techknowlogick pushed a commit that referenced this pull request Dec 6, 2023
…orkflows but other branches have (#28359) (#28365)

Backport #28359 by @lunny

The left menu will only display the default branch's workflows but the
right side will display the runs triggered by all branches' workflows.
So we cannot hide right side if default branch has no workflows.

Fix #28332 
Replace #28333

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Dec 6, 2023
follow go-gitea#28333, check workflow when pushing to branch and
save the result in database, when view the actions list,
 can get result from database quickly.

Signed-off-by: a1012112796 <1012112796@qq.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Actions" tab says "There are no workflows yet."
3 participants