-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show workflow names for other branchs on action list sidebar also #28333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick fix go-gitea#28332, do it by a quick check in `ActionRun` table. TODO: looks need more jobs about workflow lables check in future. Signed-off-by: a1012112796 <1012112796@qq.com>
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 4, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Dec 4, 2023
or looks you misunderstood the aim of this bug fix, just to show all workflow name links in sidebar, not consider about other things. |
a1012112796
changed the title
show workflow names on other branchs also
show workflow names for other branchs on action list sidebar also
Dec 4, 2023
in future, I'd like add a new table to record workflow lable status and update it on pushing to branch to enhancement this logic. type WorkflowBranch struct {
Branch string
Labels []string
ErrMsg string
}
type ActionWorkflow struct {
ID int64 `xorm:"pk autoincr"`
RepoID int64
Name string
Branchs []*WorkflowBranch `xorm:"JSON TEXT"`
ErrMsg string `json:"-"` // for ui logic
} |
techknowlogick
pushed a commit
that referenced
this pull request
Dec 6, 2023
…orkflows but other branches have (#28359) (#28365) Backport #28359 by @lunny The left menu will only display the default branch's workflows but the right side will display the runs triggered by all branches' workflows. So we cannot hide right side if default branch has no workflows. Fix #28332 Replace #28333 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Dec 6, 2023
follow go-gitea#28333, check workflow when pushing to branch and save the result in database, when view the actions list, can get result from database quickly. Signed-off-by: a1012112796 <1012112796@qq.com>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick fix #28332, do it by a quick check in
ActionRun
table.