-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated query condition in ListReleases #28339
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Maybe that PR should not be considered as breaking because it kept the compatible as before. |
After doing some digging, I found this one: https://github.com/go-gitea/gitea/pull/16175/files#diff-91fd5bc00cb24aac69be1c0504b0765185c9cf69dfd561e50b1de6c808228ca2L103 is accidentally caused the
|
* giteaofficial/main: Fix the runs will not be displayed bug when the main branch have no workflows but other branches have (go-gitea#28359) [skip ci] Updated translations via Crowdin Render PyPi long description as document (go-gitea#28272) handle repository.size column being NULL in migration v263 (go-gitea#28336) Fix migration panic due to an empty review comment diff (go-gitea#28334) Add `HEAD` support for rpm repo files (go-gitea#28309) Remove deprecated query condition in ListReleases (go-gitea#28339)
close go-gitea#24057 call stack: https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/routers/api/v1/utils/page.go#L13-L18 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/convert/utils.go#L15-L22 ##⚠️ Breaking⚠️ (though it's not caused by this PR) Do not use `per_page` to specify pagination; use `limit` instead
close go-gitea#24057 call stack: https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/routers/api/v1/utils/page.go#L13-L18 https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/convert/utils.go#L15-L22 ##⚠️ Breaking⚠️ (though it's not caused by this PR) Do not use `per_page` to specify pagination; use `limit` instead
close #24057
call stack:
gitea/routers/api/v1/repo/release.go
Line 154 in 25faee3
gitea/routers/api/v1/utils/page.go
Lines 13 to 18 in ec1feed
gitea/services/convert/utils.go
Lines 15 to 22 in ec1feed
Do not use
per_page
to specify pagination; uselimit
instead