Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect default value of [attachment].MAX_SIZE #28373

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix incorrect default value of [attachment].MAX_SIZE #28373

merged 1 commit into from
Dec 6, 2023

Conversation

capvor
Copy link
Contributor

@capvor capvor commented Dec 6, 2023

In the documents, the [attachment] MAX_SIZE default value should be 4.

Reference the source code modules/setting/attachment.go line 29.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@capvor
Copy link
Contributor Author

capvor commented Dec 6, 2023

I have found the #28100 change modules/setting/attachment.go line 16 MaxSize from 4 to 2048. It is correct???

@capvor
Copy link
Contributor Author

capvor commented Dec 6, 2023 •
edited
Loading

I have found the #28100 change modules/setting/attachment.go line 16 MaxSize from 4 to 2048. It is correct???

Maybe it is the #28100 forget change the modules/setting/attachment.go line 29 from 4 to 2048 ??

@lng2020

@lng2020
Copy link
Member

lng2020 commented Dec 6, 2023 •
edited
Loading

It should be 2048.

Reference the source code modules/setting/attachment.go to line 29.

Can you change it to 2048 in this PR? Thank you.

I only test it when my ini file doesn't have attachment section, thus leading to this negligence.

@lng2020 lng2020 added the backport/v1.21 This PR should be backported to Gitea 1.21 label Dec 6, 2023
@capvor capvor changed the title Fix docs for attachment MAX_SIZE default value Fix the MAX_SIZE default value of attachment Dec 6, 2023
@capvor
Copy link
Contributor Author

capvor commented Dec 6, 2023

@lng2020 have changed

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 6, 2023
@delvh delvh changed the title Fix the MAX_SIZE default value of attachment Fix incorrect default value of [attachment].MAX_SIZE Dec 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 6, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 6, 2023
@techknowlogick techknowlogick merged commit c1b86ec into go-gitea:main Dec 6, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 6, 2023
@GiteaBot GiteaBot mentioned this pull request Dec 6, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 6, 2023
@capvor @GiteaBot
Fix incorrect default value of [attachment].MAX_SIZE (go-gitea#28373)
71de1ca
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 6, 2023
@lng2020 lng2020 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 6, 2023
lunny pushed a commit that referenced this pull request Dec 6, 2023
@GiteaBot @capvor
Fix incorrect default value of [attachment].MAX_SIZE (#28373) (#28376)
8f2805f 
Backport #28373 by @capvor

In the documents, the `[attachment] MAX_SIZE` default value should be 4.

Reference the source code `modules/setting/attachment.go` line 29.

Co-authored-by: capvor <capvor@sina.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
13beca8 
* giteaofficial/main:
  Improve text in Security settings (go-gitea#28393)
  Fix Docker meta action for releases (go-gitea#28232)
  Make gogit Repository.GetBranchNames consistent (go-gitea#28348)
  Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (go-gitea#28220)
  Include public repos in doer's dashboard for issue search (go-gitea#28304)
  Issue fixes for RSS feed improvements (go-gitea#28380)
  Fix margin in server signed signature verification view (go-gitea#28379)
  [skip ci] Updated translations via Crowdin
  Fix incorrect run order of action jobs (go-gitea#28367)
  Improve RSS feed icons (go-gitea#28368)
  Use `filepath` instead of `path` to create SQLite3 database file (go-gitea#28374)
  Fix incorrect default value of `[attachment].MAX_SIZE` (go-gitea#28373)
  Fix object does not exist error when checking citation file (go-gitea#28314)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@capvor @fuxiaohei
Fix incorrect default value of [attachment].MAX_SIZE (go-gitea#28373)
cf22536
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@capvor @silverwind
Fix incorrect default value of [attachment].MAX_SIZE (go-gitea#28373)
ddc6e4b
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@capvor @lng2020 @delvh @techknowlogick @GiteaBot