Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint for not implemented Docker auth (#28457) #28462

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add endpoint for not implemented Docker auth (#28457) #28462

merged 1 commit into from
Dec 13, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #28457 by @KN4CK3R

Recently Docker started to use the optional POST /v2/token endpoint which should respond with a 404 Not Found status code instead of the current 405 Method Not Allowed.

Note: Not all token servers implement oauth2. If the request to the endpoint returns 404 using the HTTP POST method, refer to Token Documentation for using the HTTP GET method supported by all token servers.

@KN4CK3R @GiteaBot
Add endpoint for not implemented Docker auth (go-gitea#28457)
23a56bd 
Recently Docker started to use the optional `POST /v2/token` endpoint
which should respond with a `404 Not Found` status code instead of the
current `405 Method Not Allowed`.

> Note: Not all token servers implement oauth2. If the request to the
endpoint returns 404 using the HTTP POST method, refer to Token
Documentation for using the HTTP GET method supported by all token
servers.
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them topic/packages type/enhancement An improvement of existing functionality labels Dec 13, 2023
@GiteaBot GiteaBot added this to the 1.21.3 milestone Dec 13, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 13, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2023
@KN4CK3R KN4CK3R merged commit 74ab798 into go-gitea:release/v1.21 Dec 13, 2023
25 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

@KN4CK3R KN4CK3R

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/packages type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.3
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @KN4CK3R @delvh