Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve possible performance bottleneck #28547

Merged
merged 4 commits into from
Dec 21, 2023
Merged

improve possible performance bottleneck #28547

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74ca4a4
improve possible performance bottleneck
lunny Dec 20, 2023
47746ad
don't interate repository
lunny Dec 21, 2023
0273d53
Merge branch 'main' into lunny/avoid_update_where_in
lunny Dec 21, 2023
a8bf409
Merge branch 'main' into lunny/avoid_update_where_in
GiteaBot Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions models/issues/comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,22 +1160,20 @@ func DeleteComment(ctx context.Context, comment *Comment) error {

// UpdateCommentsMigrationsByType updates comments' migrations information via given git service type and original id and poster id
func UpdateCommentsMigrationsByType(ctx context.Context, tp structs.GitServiceType, originalAuthorID string, posterID int64) error {
_, err := db.GetEngine(ctx).Table("comment").
Where(builder.In("issue_id",
builder.Select("issue.id").
From("issue").
InnerJoin("repository", "issue.repo_id = repository.id").
Where(builder.Eq{
"repository.original_service_type": tp,
}),
)).
And("comment.original_author_id = ?", originalAuthorID).
Update(map[string]any{
"poster_id": posterID,
"original_author": "",
"original_author_id": 0,
})
return err
return db.Iterate[repo_model.Repository](ctx, builder.Eq{
"repository.original_service_type": tp,
}, func(ctx context.Context, repo *repo_model.Repository) error {
_, err := db.GetEngine(ctx).Table("comment").
Join("INNER", "issue", "issue.id = comment.issue_id").
Where("issue.repo_id=?", repo.ID).
And("comment.original_author_id = ?", originalAuthorID).
Update(map[string]any{
"poster_id": posterID,
"original_author": "",
"original_author_id": 0,
})
return err
})
}

// CreateAutoMergeComment is a internal function, only use it for CommentTypePRScheduledToAutoMerge and CommentTypePRUnScheduledToAutoMerge CommentTypes
Expand Down