-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont load Review if Comment is CommentTypeReviewRequest #28551
Merged
6543
merged 17 commits into
go-gitea:main
from
6543-forks:no_error-when-notfound-is-expected
Feb 13, 2024
Merged
Dont load Review if Comment is CommentTypeReviewRequest #28551
6543
merged 17 commits into
go-gitea:main
from
6543-forks:no_error-when-notfound-is-expected
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 20, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Dec 20, 2023
6543
changed the title
RequestReview get deleted on review. So we dont have to try to load t…
Dont load Review if Comment is CommentTypeReviewRequest
Dec 20, 2023
6 tasks
pull-request-size
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Dec 20, 2023
delvh
reviewed
Dec 30, 2023
pull-request-size
bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 30, 2023
delvh
approved these changes
Dec 30, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 30, 2023
lunny
reviewed
Dec 31, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 13, 2024
wxiaoguang
reviewed
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #28551 (comment)
6543
commented
Feb 12, 2024
silverwind
approved these changes
Feb 13, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 13, 2024
wxiaoguang
approved these changes
Feb 13, 2024
I was unable to create a backport for 1.21. @6543, please send one manually. 🍵
|
GiteaBot
added
the
backport/manual
No power to the bots! Create your backport yourself!
label
Feb 13, 2024
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 13, 2024
RequestReview get deleted on review. So we don't have to try to load them on comments. broken out go-gitea#28544
-> #29160 |
silverwind
pushed a commit
that referenced
this pull request
Feb 13, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 14, 2024
* giteaofficial/main: (38 commits) Document how the TOC election process works (go-gitea#29135) Runner tokens are multi use (go-gitea#29153) Fix Gitpod logic of setting ROOT_URL (go-gitea#29162) Remove jQuery from the user search form in admin page (go-gitea#29151) Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551) Show `View at this point in history` for every commit (go-gitea#29122) [skip ci] Updated translations via Crowdin Add merge style `fast-forward-only` (go-gitea#28954) Use Markdown alert syntax for notes in README (go-gitea#29150) Refactor issue template parsing and fix API endpoint (go-gitea#29069) [skip ci] Updated translations via Crowdin Update some translations and fix markdown formatting (go-gitea#29099) Show more settings for empty repositories (go-gitea#29130) Update JS and PY dependencies (go-gitea#29127) Add alert blocks in markdown (go-gitea#29121) Remove obsolete border-radius on comment content (go-gitea#29128) Make blockquote border size less aggressive (go-gitea#29124) Drop "@" from email sender to avoid spam filters (go-gitea#29109) [skip ci] Updated translations via Crowdin Disallow duplicate storage paths (go-gitea#26484) ...
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 15, 2024
RequestReview get deleted on review. So we don't have to try to load them on comments. broken out go-gitea#28544
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
RequestReview get deleted on review. So we don't have to try to load them on comments. broken out go-gitea#28544
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
RequestReview get deleted on review. So we don't have to try to load them on comments. broken out go-gitea#28544 (cherry picked from commit 6fad2c8)
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/manual
No power to the bots! Create your backport yourself!
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestReview get deleted on review.
So we don't have to try to load them on comments.
broken out #28544