-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve frontend guideline #28711
Merged
wxiaoguang
merged 1 commit into
go-gitea:main
from
wxiaoguang:improve-frontend-guideline
Jan 6, 2024
Merged
Improve frontend guideline #28711
wxiaoguang
merged 1 commit into
go-gitea:main
from
wxiaoguang:improve-frontend-guideline
Jan 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 6, 2024
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jan 6, 2024
wxiaoguang
force-pushed
the
improve-frontend-guideline
branch
from
January 6, 2024 14:50
a6ead3e
to
310cf0b
Compare
wxiaoguang
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Jan 6, 2024
denyskon
approved these changes
Jan 6, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 6, 2024
yardenshoham
approved these changes
Jan 6, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 6, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jan 6, 2024
It has been a consensus for long time during reviewing: "avoiding inline styles as much as possible".
techknowlogick
pushed a commit
that referenced
this pull request
Jan 6, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 8, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Move the captcha script loader to the template which really needs it (go-gitea#28718) Suggest to use Type=simple for systemd service (go-gitea#28717) Fix incorrect URL for "Reference in New Issue" (go-gitea#28716) Avoid unnecessary 500 panic when a commit doesn't exist (go-gitea#28719) [skip ci] Updated translations via Crowdin Improve frontend guideline (go-gitea#28711) Fix panic when parsing empty pgsql host (go-gitea#28708) Add merge arrow direction and update styling (go-gitea#28523)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
It has been a consensus for long time during reviewing: "avoiding inline styles as much as possible".
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
It has been a consensus for long time during reviewing: "avoiding inline styles as much as possible".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/docs
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a consensus for long time during reviewing: "avoiding inline styles as much as possible".
Feel free to improve the wording and/or improve more guidelines.