-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show whether a PR is WIP inside popups #28975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 29, 2024
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 29, 2024
github-actions
bot
added
modifies/api
This PR adds API routes or modifies them
modifies/frontend
labels
Jan 29, 2024
lunny
reviewed
Jan 29, 2024
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Jan 29, 2024
bramhaag
force-pushed
the
draft-indicator
branch
2 times, most recently
from
January 29, 2024 15:29
7678d44
to
15a33a9
Compare
bramhaag
force-pushed
the
draft-indicator
branch
from
January 29, 2024 15:30
15a33a9
to
c8f2b69
Compare
bramhaag
changed the title
Show PR draft status in ContextPopup
Show PR WIP status in ContextPopup
Jan 29, 2024
lunny
approved these changes
Jan 29, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 29, 2024
delvh
requested changes
Jan 29, 2024
GiteaBot
added
lgtm/blocked
A maintainer has reservations with the PR and thus it cannot be merged
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 29, 2024
KN4CK3R
approved these changes
Feb 3, 2024
delvh
approved these changes
Feb 4, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/blocked
A maintainer has reservations with the PR and thus it cannot be merged
labels
Feb 4, 2024
delvh
changed the title
Show PR WIP status in ContextPopup
Include whether a PR is WIP inside popups
Feb 4, 2024
delvh
changed the title
Include whether a PR is WIP inside popups
Show whether a PR is WIP inside popups
Feb 4, 2024
delvh
added
type/enhancement
An improvement of existing functionality
topic/ui
Change the appearance of the Gitea UI
labels
Feb 4, 2024
lafriks
approved these changes
Feb 4, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 5, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Show whether a PR is WIP inside popups (go-gitea#28975) Unify password changing and invalidate auth tokens (go-gitea#27625) Unify user update methods (go-gitea#28733) Do not render empty comments (go-gitea#29039)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Fixes https://codeberg.org/forgejo/forgejo/issues/2257 Draft status of a PR is currently not exposed by the API. This PR adds a 'draft' field to pull requests in the API, which is used to correctly set the PR color/icon in a ContextPopup. --- Before: ![image](https://github.com/go-gitea/gitea/assets/5541521/72cbd30e-1175-4338-aa97-ac99c46c5118) After: ![image](https://github.com/go-gitea/gitea/assets/5541521/111c9eba-460e-4d57-bcca-23a151c3a4f1)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
topic/ui
Change the appearance of the Gitea UI
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://codeberg.org/forgejo/forgejo/issues/2257
Draft status of a PR is currently not exposed by the API. This PR adds a 'draft' field to pull requests in the API, which is used to correctly set the PR color/icon in a ContextPopup.
Before:
After: