Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactor for git http #28995

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Some refactor for git http #28995

merged 4 commits into from
Jan 31, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 31, 2024

Purpose

This PR makes git http related functions use the same context.Context so they can be maintained easier.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 31, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2024
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that it is clearer and more maintainable at the same time…

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 31, 2024
@lunny lunny enabled auto-merge (squash) January 31, 2024 14:58
@lunny lunny merged commit 3b50dd9 into go-gitea:main Jan 31, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 31, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 31, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 1, 2024
* origin/main:
  [skip ci] Updated translations via Crowdin
  Fix UI Spacing Errors in mirror settings (go-gitea#28990)
  Add htmx guidelines (go-gitea#28993)
  Some refactor for git http (go-gitea#28995)
  Fix an actions schedule bug (go-gitea#28942)
  Fix doc img path in profile readme (go-gitea#28994)
  Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (go-gitea#28908)
  Fix joins in `db.Find(AndCount)` (go-gitea#28978)
  Update golang links to use https (go-gitea#28980)
  Fix google logo in security page (go-gitea#28982)
@lunny lunny deleted the lunny/refactor_githttp branch February 1, 2024 02:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 1, 2024
* giteaofficial/main:
  Revert "Speed up loading the dashboard on mysql/mariadb (go-gitea#28546)" (go-gitea#29006)
  Update dorny/paths-filter action (go-gitea#29003)
  [skip ci] Updated translations via Crowdin
  Fix UI Spacing Errors in mirror settings (go-gitea#28990)
  Add htmx guidelines (go-gitea#28993)
  Some refactor for git http (go-gitea#28995)
  Fix an actions schedule bug (go-gitea#28942)
  Fix doc img path in profile readme (go-gitea#28994)
  Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (go-gitea#28908)
  Fix joins in `db.Find(AndCount)` (go-gitea#28978)
  Update golang links to use https (go-gitea#28980)
  Fix google logo in security page (go-gitea#28982)
  Also match weakly validated ETags (go-gitea#28957)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
# Purpose

This PR makes git http related functions use the same `context.Context`
so they can be maintained easier.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants