Hide code links on release page if user cannot read code #29064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
type/bug
topic/ui
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
lunny
approved these changes
Feb 6, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Feb 6, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 6, 2024
) On the release list page, if the user doesn't have the permission to read code, the code links will lead to 404 pages or api errors: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a74fbc63-6dd6-43c6-853c-28acdbfdcb4e"> After this PR: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a626373d-c2df-40a9-8fed-1b12ff6bc56f"> And this PR also removed some dead code. After go-gitea#23465, the tag list page has an independent template, and all `IsTag` in the release list template are always false.
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Feb 6, 2024
…9066) Backport #29064 by @wolfogre On the release list page, if the user doesn't have the permission to read code, the code links will lead to 404 pages or api errors: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a74fbc63-6dd6-43c6-853c-28acdbfdcb4e"> After this PR: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a626373d-c2df-40a9-8fed-1b12ff6bc56f"> And this PR also removed some dead code. After #23465, the tag list page has an independent template, and all `IsTag` in the release list template are always false. Co-authored-by: Jason Song <i@wolfogre.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 7, 2024
* giteaofficial/main: Hide code links on release page if user cannot read code (go-gitea#29064) [skip ci] Updated translations via Crowdin Don't do a full page load when clicking `Watch` or `Star` (go-gitea#29001) Remove useless template file (go-gitea#29053) Fix typos in the documentation (go-gitea#29048) Move some repository transfer functions to service layer (go-gitea#28855) Propagate install_if and provider_priority to APKINDEX (go-gitea#28899)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
) On the release list page, if the user doesn't have the permission to read code, the code links will lead to 404 pages or api errors: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a74fbc63-6dd6-43c6-853c-28acdbfdcb4e"> After this PR: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a626373d-c2df-40a9-8fed-1b12ff6bc56f"> And this PR also removed some dead code. After go-gitea#23465, the tag list page has an independent template, and all `IsTag` in the release list template are always false.
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
…gitea#29064) On the release list page, if the user doesn't have the permission to read code, the code links will lead to 404 pages or api errors: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a74fbc63-6dd6-43c6-853c-28acdbfdcb4e"> After this PR: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a626373d-c2df-40a9-8fed-1b12ff6bc56f"> And this PR also removed some dead code. After go-gitea#23465, the tag list page has an independent template, and all `IsTag` in the release list template are always false. (cherry picked from commit f9072db)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the release list page, if the user doesn't have the permission to read code, the code links will lead to 404 pages or api errors:
After this PR:
And this PR also removed some dead code. After #23465, the tag list page has an independent template, and all
IsTagin the release list template are always false.