Don't do a full page load when searching code #29138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
reviewed
Feb 13, 2024
| $(document).on('click', '.fold-container .fold-button', ({currentTarget}) => { | ||
| invertFileFolding(currentTarget.closest('.fold-container'), currentTarget); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can we use a <details> element for the toggle mechanism instead of this JS? I know it can be (ab)used for a lot of use cases, so I think it's suitable.
| @@ -42,8 +43,15 @@ func Code(ctx *context.Context) { | |||
| ctx.Data["queryType"] = queryType | |||
| ctx.Data["PageIsViewCode"] = true | |||
|
|
|||
| isHtmxRequest := len(ctx.Req.Header.Values("HX-Request")) > 0 | |||
There was a problem hiding this comment.
Suggested change
| isHtmxRequest := len(ctx.Req.Header.Values("HX-Request")) > 0 | |
| isHtmxRequest := ctx.Req.Header.Get("HX-Request") == "true" |
|
Using htmx without careful design would cause some "init" problems (see #29385 (comment) and #33854 ) About this PR: it is stale for long time, I then the benefit it brings is less than the maintainability cost. Feel free to reopen if there would be a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't do a full page load when searching code and fold the result