-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the content when object is unexpected in git.Repository.getTree
(no go-git)
#29253
Conversation
getTree
Can you add a test? |
I will try, but it occurs randomly, need to consider how to test it correctly. 🤔 |
git.Repository.getTree
(no go-git)
My fix from #29104 prevented the error too but doesn't fix the real problem. Should be the same for this fix. Gave up at that point then. I may have a look at this again later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark as "request changes":
- The root cause should be figured out
- It needs tests and comments
@yp05327 Are you fine with it if I would create a new PR containing your commit because there are other places too which should be changed. Otherwise we can merge your PR and I create a follow up PR. |
Never mind. I will close this one. |
Automatically locked because of our CONTRIBUTING guidelines |
Fix #29101
cat-file --batch
output format:When object type is expected, the content will be handled, but when it is not expected, the content will not be handled, and will be read in the next turn.