Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty repo for CreateRepository in action notifier #29416

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Ignore empty repo for CreateRepository in action notifier #29416

merged 4 commits into from
Feb 26, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 26, 2024

Fix #29415

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2024
@yp05327 yp05327 requested a review from wolfogre February 26, 2024 07:03
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2024
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 26, 2024
KN4CK3R
KN4CK3R reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just check the input.Repo.IsEmpty property somewhere near the top to avoid opening the repo and unit loading?

@lng2020
Copy link
Member

lng2020 commented Feb 26, 2024 •
edited
Loading

I think so too. It should be a check after opening the git repo or a check for input.Repo.
Update:

if input.Repo.IsEmpty {
  return nil
}

works for me

@yp05327
Copy link
Contributor Author

yp05327 commented Feb 26, 2024

Can't you just check the input.Repo.IsEmpty property somewhere near the top to avoid opening the repo and unit loading?

Done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 26, 2024
@lunny lunny enabled auto-merge (squash) February 26, 2024 08:52
@lunny lunny merged commit 403766c into go-gitea:main Feb 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 26, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 26, 2024
@yp05327 @GiteaBot
Ignore empty repo for CreateRepository in action notifier (go-gitea#2…
408576d 
…9416)

Fix go-gitea#29415
@GiteaBot GiteaBot mentioned this pull request Feb 26, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 26, 2024
lunny pushed a commit that referenced this pull request Feb 26, 2024
@GiteaBot @yp05327
Ignore empty repo for CreateRepository in action notifier (#29416) (#…
c758a8a 
…29424)

Backport #29416 by @yp05327

Fix #29415

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ddef710 
* giteaofficial/main:
  Fix mail template error (go-gitea#29410)
  Document our issue locking policy (go-gitea#29433)
  Fix htmx rendering the login page in frame on session logout (go-gitea#29405)
  Ignore empty repo for CreateRepository in action notifier (go-gitea#29416)
  Fix incorrect tree path value for patch editor (go-gitea#29377)
  Fix logic error from go-gitea#28138 (go-gitea#29417)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
@yp05327 yp05327 deleted the fix-29415 branch March 13, 2024 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lunny lunny lunny approved these changes

@wolfogre wolfogre Awaiting requested review from wolfogre

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
6 participants
@yp05327 @lng2020 @lunny @KN4CK3R @Zettat123 @GiteaBot