Refactor the "attachments" sub-template data key to RenderedContent #29517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
the
modifies/templates
lunny
approved these changes
Mar 1, 2024
GiteaBot
added
lgtm/need 1
yardenshoham
approved these changes
Mar 1, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 1, 2024
* giteaofficial/main: Set pre-step status to `skipped` if job is skipped (go-gitea#29489) Use a predictiable fork URL to allow forking repositories without providing a repo ID (go-gitea#29519) Adding back missing options to app.example.ini (go-gitea#29511) Refactor the "attachments" sub-template data key to RenderedContent (go-gitea#29517) Rename Str2html to SanitizeHTML and clarify its behavior (go-gitea#29516) Add admin API route for managing user's badges (go-gitea#23106) Refactor some Str2html code (go-gitea#29397) Move migration functions to services layer (go-gitea#29497)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value passed into "attachments" sub-template is from "RedneredContent", so use the same name for consistent. And it makes readers easy to know its data type.