Support pasting URLs over markdown text #29566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
added
type/enhancement
silverwind
force-pushed
the
urlpaste
branch
2 times, most recently
from
7464329
to
2644272
Compare
silverwind
added
type/enhancement
|
I think this can be barely called a feature, so not flagging it. Edit: Actually decided against :) |
techknowlogick
approved these changes
Mar 4, 2024
GiteaBot
added
lgtm/need 1
KN4CK3R
reviewed
Mar 5, 2024
|
Ready again. |
KN4CK3R
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 8, 2024
* giteaofficial/main: Fix commit_status problem when testing (go-gitea#29672) Support pasting URLs over markdown text (go-gitea#29566) bump python version to 3.12 in dev container (go-gitea#29670)
silverwind
added
the
type/feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support pasting URLs over selection text in the textarea editor. Does not work in EasyMDE and I don't intend to support it. Image paste works as usual in both Textarea and EasyMDE.
The new
replaceTextareaSelectionfunction changes textarea content viainsertTextcommand, which preserves history, e.g.CTRL-Zworks and is also demostrated below. We should later refactor the image paste code to use the same function because it currently destroys history.Overriding the formatting via
Shiftkey is supported as well, e.g.Ctrl+Shift+Vwill insert the URL as-is, like on GitHub.