Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add config option to enable/disable default fuzzy search #29589

Closed
wants to merge 3 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 4, 2024

explicit enable or disable it should be an UI option


Sponsored by Kithara Software GmbH

explizite enable or disable it should be an UI option
@6543 6543 added type/enhancement An improvement of existing functionality pr/wip This PR is not ready for review labels Mar 4, 2024
@6543 6543 added this to the 1.23.0 milestone Mar 4, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2024
@silverwind

This comment was marked as off-topic.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2024
@silverwind
Copy link
Member

  1. Would reword: "Whether to use futty search by default in the issue, if the indexer supports it".
  2. Can we cut out the by default? What does it refer to?
  3. I think the UI dropdown's default option will need to be adjusted.

@6543
Copy link
Member Author

6543 commented Mar 4, 2024

to 2. I want to have an option in the UI later on that enable/disable fuzzyness and to not have the key in settings changed, i named it, so it can server as default value ... later on

anyway, currently if you switch from bleach to meilisearch, you will get a lot of unrelated issues in issue search ...

@silverwind
Copy link
Member

silverwind commented Mar 4, 2024

to 2. I want to have an option in the UI later on that enable/disable fuzzyness and to not have the key in settings changed, i named it, so it can server as default value ... later on

The code search has this already, but I think for issue search we should support is via keyword mode:fuzzy or something.

image

anyway, currently if you switch from bleach to meilisearch, you will get a lot of unrelated issues in issue search ...

Yeah, sounds like a bug. We should strive to configure indexers so they yield similar results.

@6543
Copy link
Member Author

6543 commented Mar 10, 2024

use-case will be addressed by #29701

@6543 6543 closed this Mar 10, 2024
@6543 6543 deleted the config/INDEXER_DEFAULT_FUZZY branch March 10, 2024 01:45
@GiteaBot GiteaBot removed this from the 1.23.0 milestone Mar 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/docs pr/wip This PR is not ready for review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants