Skip to content

Fix contributor graphs mobile layout and responsiveness #29597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix contributor graphs mobile layout and responsiveness #29597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9e421b
Fix contributor grid responsiveness
silverwind Mar 4, 2024
ddcafe4
apply further tweaks from issue comments
silverwind Mar 4, 2024
f7a4f34
Merge branch 'main' into cgrid
GiteaBot Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions web_src/js/components/RepoContributors.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export default {
</script>
<template>
<div>
<h2 class="ui header gt-df gt-ac gt-sb">
<div class="ui header gt-df gt-ac gt-sb">
<div>
<relative-time
v-if="xAxisMin > 0"
Expand Down Expand Up @@ -334,7 +334,7 @@ export default {
<div class="ui dropdown jump" id="repo-contributors">
<div class="ui basic compact button">
<span class="text">
{{ locale.filterLabel }} <strong>{{ locale.contributionType[type] }}</strong>
<span class="not-mobile">{{ locale.filterLabel }}&nbsp;</span><strong>{{ locale.contributionType[type] }}</strong>
<svg-icon name="octicon-triangle-down" :size="14"/>
</span>
</div>
Expand All @@ -351,7 +351,7 @@ export default {
</div>
</div>
</div>
</h2>
</div>
<div class="gt-df ui segment main-graph">
<div v-if="isLoading || errorText !== ''" class="gt-tc gt-m-auto">
<div v-if="isLoading">
Expand All @@ -370,7 +370,8 @@ export default {
</div>
<div class="contributor-grid">
<div
v-for="(contributor, index) in sortedContributors" :key="index" class="stats-table"
v-for="(contributor, index) in sortedContributors"
:key="index"
v-memo="[sortedContributors, type]"
>
<div class="ui top attached header gt-df gt-f1">
Expand Down Expand Up @@ -406,13 +407,25 @@ export default {
<style scoped>
.main-graph {
height: 260px;
padding-top: 2px;
}

.contributor-grid {
display: grid;
grid-template-columns: repeat(2, 1fr);
gap: 1rem;
}

.contributor-grid > * {
min-width: 0;
}

@media (max-width: 991.98px) {
.contributor-grid {
grid-template-columns: repeat(1, 1fr);
}
}

.contributor-name {
margin-bottom: 0;
}
Expand Down