Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty repo check in DetectAndHandleSchedules #29606

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Add empty repo check in DetectAndHandleSchedules #29606

merged 2 commits into from
Mar 5, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 5, 2024

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2024
@yp05327 yp05327 requested a review from Zettat123 March 5, 2024 07:22
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 5, 2024 •
edited
Loading

@lunny
maybe we can add a function for gitRepo.GetCommit() in gitrepo to avoid this again?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 5, 2024
@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Mar 5, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 5, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 5, 2024
@lunny lunny enabled auto-merge (squash) March 5, 2024 09:29
@lunny lunny merged commit 3f3335a into go-gitea:main Mar 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 5, 2024
@GiteaBot
Copy link
Contributor

GiteaBot commented Mar 5, 2024

I was unable to create a backport for 1.21. @yp05327, please send one manually. 🍵

go run ./contrib/backport 29606
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 5, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
810335f 
* giteaofficial/main:
  Run editorconfig-checker on `locale_en-US.ini` (go-gitea#29608)
  bump protobuf module (go-gitea#29617)
  Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (go-gitea#29584)
  Skip email domain check when admins edit user emails (go-gitea#29609)
  Improve natural sort (go-gitea#29611)
  Add empty repo check in `DetectAndHandleSchedules` (go-gitea#29606)
  Fix contributor graphs mobile layout and responsiveness (go-gitea#29597)
  Skip email domain check when admin users adds user manually (go-gitea#29522)
  Replace more `gt-` with `tw-`, update frontend docs (go-gitea#29595)
  Remove unnecessary ctxData for "attachments" template (go-gitea#29600)
  Adjust tailwind content globs (go-gitea#29596)
  Use flex wrap to layout the PR update button (go-gitea#29590)
  Make "/user/login" page redirect if the current user has signed in (go-gitea#29583)
  [skip ci] Updated translations via Crowdin
  Fix projects mode bugs (go-gitea#29593)
  Regenerate fomantic lockfile and build it with our browserslist (go-gitea#29560)
  Do not exceed display for the PR page buttons on smaller screens (go-gitea#29418)
  Add aria-label to the navbar menu button (go-gitea#29587)
@yp05327 yp05327 deleted the fix-error-in-detectandhandleschedules branch March 6, 2024 23:58
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 8, 2024
@yp05327 yp05327 mentioned this pull request Mar 8, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 8, 2024
silverwind pushed a commit that referenced this pull request Mar 8, 2024
@yp05327
Add empty repo check in DetectAndHandleSchedules (#29606) (#29659)
bd7de0c 
Backport #29606
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @GiteaBot @lunny @Zettat123