Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve a11y document and dropdown item #29753

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Improve a11y document and dropdown item #29753

merged 5 commits into from
Mar 13, 2024

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 13, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2024
@wxiaoguang @lunny
Update web_src/js/modules/fomantic/aria.md
ce82e68 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@jolheiser
Copy link
Member

The fix for this seems similar to https://codeberg.org/forgejo/forgejo/pulls/2636

Is there some credit that should be added here?

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 13, 2024 •
edited
Loading

Is there some credit that should be added here?

Feel free to edit this PR directly (I am not sure about how to do it correctly, meanwhile I always agree to do the right thing)

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 13, 2024 •
edited
Loading

The fix for this seems similar to https://codeberg.org/forgejo/forgejo/pulls/2636

Is there some credit that should be added here?

By taking a deep look, I do not think there is a strong requirement for either side. Because for example: https://codeberg.org/forgejo/forgejo/pulls/2642 , this has been fixed on Gitea side days ago.

image

@wxiaoguang @silverwind
Update web_src/js/modules/fomantic/aria.md
b9f6db5 
Co-authored-by: silverwind <me@silverwind.io>
@wxiaoguang @silverwind
Update web_src/js/modules/fomantic/aria.md
e2bbfbe 
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 13, 2024 13:41
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2024
@wxiaoguang wxiaoguang merged commit e01b001 into go-gitea:main Mar 13, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 13, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2024
@wxiaoguang wxiaoguang deleted the fix-aria branch March 13, 2024 13:48
@lunny lunny removed this from the 1.23.0 milestone Mar 13, 2024
@lunny lunny added this to the 1.22.0 milestone Mar 13, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 13, 2024
@silverwind
Merge branch 'main' into overflow-menu
b1e4857 
* main:
  fix missed RenderLabel change in card template (go-gitea#29772)
  Fix incorrect locale Tr for gpg command (go-gitea#29754)
  Improve a11y document and dropdown item (go-gitea#29753)
  Improve QueryEscape helper function (go-gitea#29768)
  Use relative links for commits, mentions, and issues in markdown (go-gitea#29427)
  Move fork router functions to a standalone file (go-gitea#29756)
  Configure pinned JS dependencies via updates.config.js (go-gitea#29696)
  Refactor to use optional.Option for issue index search option (go-gitea#29739)
  Fix user router possbile panic (go-gitea#29751)
  Refactor label.IsArchived() (go-gitea#29750)
  Fix date rendering by adding `<gitea-absolute-date>` (go-gitea#29725)
  Update to labeler v5 (go-gitea#29721)
  Update Chroma to v2.13.0 (go-gitea#29732)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6e7fc2d 
* giteaofficial/main:
  Fix `make generate-swagger` in go 1.22 (go-gitea#29780)
  Fix incorrect menu/link on webhook edit page (go-gitea#29709)
  Add test for webhook (go-gitea#29755)
  Fix possible NPE in ToPullReviewList (go-gitea#29759)
  fix missed RenderLabel change in card template (go-gitea#29772)
  Fix incorrect locale Tr for gpg command (go-gitea#29754)
  Improve a11y document and dropdown item (go-gitea#29753)
  Improve QueryEscape helper function (go-gitea#29768)
  Use relative links for commits, mentions, and issues in markdown (go-gitea#29427)
  Move fork router functions to a standalone file (go-gitea#29756)
  Configure pinned JS dependencies via updates.config.js (go-gitea#29696)
  Refactor to use optional.Option for issue index search option (go-gitea#29739)
  Fix user router possbile panic (go-gitea#29751)
  Refactor label.IsArchived() (go-gitea#29750)
@oliverpool
Copy link
Contributor

Because for example: https://codeberg.org/forgejo/forgejo/pulls/2642 , this has been fixed on Gitea side days ago.

@wxiaoguang if you read your counter-example to the end you can see that:

  • I didn’t saw it was fixed in Gitea when I opened the PR
  • As soon as I became aware, I closed my PR in favor of the cherry-pick (which preserved the original commit, so full attribution to the committer)

@wxiaoguang
Copy link
Contributor Author

Thank you for you explanation.

And this PR was started for #29400 (comment) to address my concern for the new "menu" (Mar 7, 2024). I reviewed the documents and the dropdown implementation and improved them.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/js size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @jolheiser @oliverpool @lunny @silverwind @GiteaBot