Suppress error from monaco-editor (#29684) #29758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: go-gitea#29414 I see no way for us to catch this error, so downgrade it until microsoft/monaco-editor#4325 is fixed, which will likely take a few weeks to propagate up from vscode. The entries in `updates.config.js` will make [`updates`](https://github.com/silverwind/updates) not upgrade these anymore and I think it's good documentation as well to have the reasons why we don't upgrade these dependencies.
GiteaBot
added
modifies/frontend
skip-changelog
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Mar 13, 2024
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Mar 13, 2024
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #29684 by @silverwind
Fixes: #29414
I see no way for us to catch this error, so downgrade it until microsoft/monaco-editor#4325 is fixed, which will likely take a few weeks to propagate up from vscode.
The entries in
updates.config.jswill makeupdatesnot upgrade these anymore and I think it's good documentation as well to have the reasons why we don't upgrade these dependencies.