Add optional.ExtractValue() to be able to handle Option type within interface{} value

[6543]

as title ... add an helper func for optional.Option type(s)

because simple type cast wont work if you not know the exact T type too ... (or want your func handle all Option Types ...)

[KN4CK3R]

What's the usecase of this?

[6543]

usecase would be to make

gitea/routers/web/user/home.go

Line 335 in 487ac9b

pager.AddParam(ctx, "state", "State")

optional.Option aware etc...

[6543]

should I add this usecase in here too?

[6543]

@lunny @KN4CK3R added an example usage

[KN4CK3R]

How/Where gets the optional.Option into ctx.Data?

[6543]

if we start to adopt and use optionals more widly instead of type refs ...
e.g.
https://github.com/go-gitea/gitea/pull/29726/files#diff-aa8a6ecda61a1825f948895bec48df575bee830dd5c3d25fd81977452041945cR131-R133

[wxiaoguang]

Actually IMO the design of AddParam is totally wrong. It should add the key/value explicitly, but not depending on the "ctx.Data"

If the AddParam could be implemented clearly, then no need the ExtractValue trick.

---

For example, when I read the code: pager.AddParam(ctx, "search", "search"), the question always comes into my mind: what is it doing? Where is the value from? Why "search" / "search" ?

[wxiaoguang]

-> Refactor AddParam to AddParamIfExist #29834

[6543]

In this regards it looks like it is not jet needed, so I'll close this pull and everybody is free to pick that patch if needed in the future