Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scrollbar customizations #29800

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Remove scrollbar customizations #29800

merged 3 commits into from
Mar 15, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 14, 2024 •
edited
Loading

Fixes #29652. Removes all scrollbar customization as per popular vote on #29652 (comment).

There is one more case of -webkit-scrollbar left in CSS and #29400 will get rid of that as well.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024
@silverwind silverwind mentioned this pull request Mar 14, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) March 15, 2024 04:40
@techknowlogick techknowlogick added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. topic/ui Change the appearance of the Gitea UI labels Mar 15, 2024
@techknowlogick techknowlogick merged commit 0827552 into go-gitea:main Mar 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 15, 2024
@silverwind silverwind deleted the scroll branch March 15, 2024 08:31
@mrexodia
Copy link
Contributor

Thanks, I appreciate the quick fix a lot!

@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 16, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Gitea Scrollbar is ugly (again)
7 participants
@silverwind @mrexodia @techknowlogick @delvh @GiteaBot @6543 @wxiaoguang