Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fomantic message module #29856

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Remove fomantic message module #29856

merged 1 commit into from
Mar 17, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 16, 2024 •
edited
Loading

Remove this CSS-only module, which gives a nice reduction in CSS size. Should look exactly like before.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 16, 2024
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 16, 2024
@github-actions github-actions bot added modifies/frontend and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 16, 2024
@silverwind silverwind mentioned this pull request Mar 16, 2024
Closed
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2024
@wxiaoguang wxiaoguang merged commit 4e54782 into go-gitea:main Mar 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 17, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 17, 2024 •
edited
Loading

Sorry I merged this too fast (by mistake ....)

I didn't see related changes in semantic.json. So next make fomantic would still generate these "message" classes?

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 17, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
28b16f6 
* giteaofficial/main:
  Fix PR creation via api between branches of same repo with head field namespaced (go-gitea#26986)
  Remove fomantic message module (go-gitea#29856)
  fix double border and border-radius on empty action steps (go-gitea#29845)
  add `.suppressed` link class (go-gitea#29847)
@silverwind silverwind deleted the rmmsg branch March 17, 2024 08:10
@silverwind
Copy link
Member Author

Ah, i reverted the setting once, yes I will follow up.

This was referenced Mar 17, 2024
Merged
Open
silverwind added a commit that referenced this pull request Mar 17, 2024
@silverwind
Fix semantic.json (#29860)
c20b568 
Followup #29856
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 17, 2024
@silverwind
Remove fomantic message module (go-gitea#29856)
df5ab0c 
Remove this CSS-only module, which gives a nice reduction in CSS size.
Should look exactly like before.
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 17, 2024
@silverwind
Fix semantic.json (go-gitea#29860)
ac00197 
Followup go-gitea#29856
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Mar 20, 2024
@silverwind @earl-warren
Fix semantic.json (#29860)
f4ed953 
Followup go-gitea/gitea#29856

(cherry picked from commit c20b56815d4f27ffd1b457ec238e494adc5fba81)
@lunny lunny removed this from the 1.23.0 milestone Mar 22, 2024
@lunny lunny added this to the 1.22.0 milestone Mar 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @wxiaoguang @techknowlogick @lunny @GiteaBot