Build backend before integrations test #29957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
topic/build
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Mar 21, 2024
GiteaBot
added
lgtm/need 1
This reverts commit ff8d029.
|
Give it up, since it seems by design. I noticed that the workflow files sometimes work like "build binary with some tags, but run tests with other tags." 
|
silverwind
requested review from
GiteaBot and
silverwind
and removed request for
GiteaBot and
silverwind
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems integration tests require the Gitea binary (maybe use it as git hooks?).
gitea/tests/integration/integration_test.go
Line 89 in 3ee39db
If I delete the old binary then
make test-sqlite, it will fail. So letintegrations.*.testdepends onbackend.