-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor repo header/list #29969
Refactor repo header/list #29969
Conversation
Sidenote: longterm we should use the tailwind responsive prefixes over |
It could be. At the moment, "not-mobile" and "mobile-only" have been widely used. So I think it's good to keep using them, and refactor them together later. |
Oh by the way, I think for this special case, "not-mobile" and "mobile-only" are still good enough. And they selectors need to be doubled to win the chance (see the old comment) |
Yeah we need to work out how to use those tailwind classes. To me it's confusing that they use |
I wonder, can we figure out a tailwind class that does what |
Huh, according to the CSS diff the class was only on |
I see the 4 matches:
Can we at least rename it to |
Yup, there were 4 matches, and I added 4~5 in this PR, not too many, and they have a clear / non-conflicting name, it could be easily refactored later (which is not in this PR's scope)
If you really would like: 8cda574 |
* origin/main: (332 commits) Refactor external URL detection (go-gitea#29973) Refactor repo header/list (go-gitea#29969) Fix various loading states, remove `.loading` class (go-gitea#29920) Update register application URL for GitLab (go-gitea#29959) Refactor StringsToInt64s (go-gitea#29967) Switch to happy-dom for testing (go-gitea#29948) Performance improvements for pull request list page (go-gitea#29900) Refactor URL detection (go-gitea#29960) Solving the issue of UI disruption when the review is deleted without refreshing (go-gitea#29951) Fix JS error and improve error message styles (go-gitea#29963) Fix the bug that user may logout if he switch pages too fast (go-gitea#29962) Cancel previous runs of the same PR automatically (go-gitea#29961) Exclude `routers/private/tests` from air (go-gitea#29949) Remove codecov badge (go-gitea#29950) Misc color tweaks (go-gitea#29943) Fix and rewrite markup anchor processing (go-gitea#29931) Remove fomantic grid module (go-gitea#29894) Add background to dashboard navbar, fix missing padding (go-gitea#29940) Prevent layout shift in `<overflow-menu>` items (go-gitea#29831) Fix loadOneBranch panic (go-gitea#29938) ...
* giteaofficial/main: Fix bugs in rerunning jobs (go-gitea#29955) remove PATH and GOPATH modification in Makefile (go-gitea#29978) Refactor external URL detection (go-gitea#29973) Refactor repo header/list (go-gitea#29969) Fix various loading states, remove `.loading` class (go-gitea#29920) Update register application URL for GitLab (go-gitea#29959) Refactor StringsToInt64s (go-gitea#29967) Switch to happy-dom for testing (go-gitea#29948) Performance improvements for pull request list page (go-gitea#29900)
@media (max-width: 767.98px)
tricksCountFmt
for repo list, just like the repo header (and it matches GitHub, to avoid big numbers bloat the page)