Refactor file view & render (#30227) #30229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code is inconsistent and fragile, and the UI isn't right.
GiteaBot
added
modifies/go
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
approved these changes
Apr 1, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 1, 2024
GiteaBot
added
lgtm/done
delvh
approved these changes
Apr 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30227 by @wxiaoguang
The old code is inconsistent and fragile, and the UI isn't right.
This PR focuses on refactoring some legacy logic and fix the UI. Some comments are left because it seems to need more time to do deep refactorings in the future.
Before
After