-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fomantic list module #30281
Merged
Merged
Remove fomantic list module #30281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 4, 2024
pull-request-size
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Apr 4, 2024
silverwind
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Apr 4, 2024
silverwind
commented
Apr 4, 2024
github-actions
bot
added
the
modifies/templates
This PR modifies the template files
label
Apr 4, 2024
delvh
approved these changes
Apr 5, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 5, 2024
silverwind
commented
Apr 6, 2024
lafriks
approved these changes
Apr 6, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 6, 2024
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 6, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 6, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 8, 2024
* giteaofficial/main: (26 commits) Fix oauth2 builtin application logic (go-gitea#30304) [skip ci] Updated licenses and gitignores Some NuGet package enhancements (go-gitea#30280) Fix and rewrite contrast color calculation, fix project-related bugs (go-gitea#30237) Add `--page-spacing` variable, fix admin dashboard notice (go-gitea#30302) Action view mobile improvements and fixes (go-gitea#30309) Fix checkboxes on mobile view, remove some dead css (go-gitea#30308) Clean up log messages (go-gitea#30313) Fix right-aligned input icons (go-gitea#30301) Refactor startup deprecation messages (go-gitea#30305) [skip ci] Updated translations via Crowdin Remove fomantic list module (go-gitea#30281) Markup color and font size fixes (go-gitea#30282) Fix code block style for code preview (go-gitea#30298) Always use `octicon-eye` on watch button (go-gitea#30288) Fix view commit link (go-gitea#30297) Add gap to commit status details (go-gitea#30284) Update JS dependencies and add new eslint rules (go-gitea#30279) Upgrade `golang.org/x/net` to v0.24.0 (go-gitea#30283) Commit-Dropdown: Show Author of commit if available (go-gitea#30272) ... # Conflicts: # templates/base/footer_content.tmpl
AvengerMoJo
pushed a commit
to AvengerMoJo/gitea
that referenced
this pull request
Apr 8, 2024
Likely still some unnecessary CSS but any combinations with the `ui list` classes are covered. There was only on instance of `horizontal list` which I removed. It was this part of the commit page: <img width="396" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/c49ec4f5-93c3-41d6-a907-cdbedf8abc44">
lunny
pushed a commit
that referenced
this pull request
Apr 10, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Apr 16, 2024
Fixes go-gitea/gitea#30365, regression from go-gitea/gitea#30281 (cherry picked from commit fec754258cce7f82ce9263f2dd0fad3f0b078d8a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/templates
This PR modifies the template files
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely still some unnecessary CSS but any combinations with the
ui list
classes are covered. There was only on instance ofhorizontal list
which I removed. It was this part of the commit page: