Fix branch_protection api shows users/teams who has no readAccess #30291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
|
Any comment please? |
|
ping @lunny |
lunny
reviewed
Apr 13, 2024
lunny
added
backport/v1.21
….com:edwardzhanged/gitea into branch_protection_api_readAccess_enhancement
lunny
approved these changes
Apr 14, 2024
GiteaBot
added
lgtm/need 1
|
Need another approve. |
wxiaoguang
reviewed
Apr 15, 2024
wxiaoguang
reviewed
Apr 15, 2024
wxiaoguang
approved these changes
Apr 16, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.21. @edwardzhanged, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 17, 2024
…-gitea#30291) Add some logic in `convert.ToBranchProtection` to return only the names associated with readAccess instead of returning all names. This will ensure consistency in behavior between the frontend and backend. Fixes: go-gitea#27694 --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com> Co-authored-by: wenzhuo.zhang <wenzhuo.zhang@geely.com> Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
removed
the
reviewed/wait-merge
silverwind
pushed a commit
that referenced
this pull request
Apr 17, 2024
…0291) (#30544) Backport #30291 by @edwardzhanged Add some logic in `convert.ToBranchProtection` to return only the names associated with readAccess instead of returning all names. This will ensure consistency in behavior between the frontend and backend. Fixes: #27694 Co-authored-by: Edward Zhang <45360012+edwardzhanged@users.noreply.github.com> Co-authored-by: techknowlogick <techknowlogick@gitea.com> Co-authored-by: wenzhuo.zhang <wenzhuo.zhang@geely.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2024
* giteaofficial/main: Add an api test for updating user (go-gitea#30539) [skip ci] Updated translations via Crowdin Expose fuzzy search for issues/pulls (go-gitea#29701) Allow everyone to read or write a wiki by a repo unit setting (go-gitea#30495) Support nuspec manifest download for nuget packages (go-gitea#28921) Fix branch_protection api shows users/teams who has no readAccess (go-gitea#30291) Correct locale string rendering (go-gitea#30522) Run `go generate` and `go vet` on all packages (go-gitea#30529) Fix and tweak pull request commit list (go-gitea#30528) Refactor web routes (go-gitea#30519) Fix install page checkboxes and dropdown width (go-gitea#30526) # Conflicts: # routers/web/user/home.go # templates/user/dashboard/issues.tmpl
wxiaoguang
removed
backport/manual
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some logic in
convert.ToBranchProtectionto return only the names associated with readAccess instead of returning all names. This will ensure consistency in behavior between the frontend and backend.Fixes: #27694