Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): call automerge service on successful commit state #30332

Closed
wants to merge 1 commit into from

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Apr 8, 2024

The actions runner doesn't call automerge on successful commit states, so automerge never happens from actions.
It's working fine from Jenkins, because the commit status api is calling the automerge service.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 8, 2024
@viceice
Copy link
Contributor Author

viceice commented Apr 8, 2024

sure. this is a much simpler and smaller fix 🙃

@lunny
Copy link
Member

lunny commented Apr 8, 2024

sure. this is a much simpler and smaller fix 🙃

I don't think so. #30225 is simpler and reused the exist functions with no duplicated code.

@viceice viceice closed this Apr 8, 2024
@viceice viceice deleted the fix/actions/automerge branch April 8, 2024 08:50
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automerge does not work
3 participants