-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container.FilterSlice function #30339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 8, 2024
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Apr 8, 2024
lunny
reviewed
Apr 8, 2024
silverwind
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 8, 2024
oliverpool
changed the title
Add container.FilterMapUnique function
Add container.FilterSlice function
Apr 9, 2024
lunny
approved these changes
Apr 9, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 9, 2024
lunny
added
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Apr 9, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 9, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 10, 2024
* giteaofficial/main: Fix line height on inline code preview (go-gitea#30372) Refactor more filterslice (go-gitea#30370) Fix ambiguous id when fetch Actions tasks (go-gitea#30382) Fix floated list items (go-gitea#30377) Fix actions design about default actions download url (go-gitea#30360) Add container.FilterSlice function (go-gitea#30339) Fix label-list rendering in timeline, decrease gap (go-gitea#30342) Performance optimization for git push (go-gitea#30104) Reduce checkbox size to 15px (go-gitea#30346)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many places have the following logic:
this introduces a
container.FilterMapUnique
function, which reduces the code above to:(I noticed this pattern while looking at #29515)