Change the default maxPerPage for gitbucket #30392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to use an internal perPage of gitbucket as maxPerPage numer. Description is available on go-gitea#30316.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/need 1
|
Can you share a screenshot you have tested the migration? |
|
Give me a day or two. I'll be back with screenshots. |
silverwind
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/done
delvh
approved these changes
Apr 10, 2024
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 12, 2024
This patch improves the migration from gitbucket to gitea. The gitbucket uses it's own internal perPage value (= 25) for paging and ignore per_page arguments in the requested URL. This cause gitea to migrate only 25 issues and 25 PRs from gitbucket repository. This may not happens on old gitbucket. But recent gitbucket 4.40 or 4.38.4 has this problem. This patch change to use this internally hardcoded perPage of gitbucket as gitea's maxPerPage numer when migrating from gitbucket. There are several perPage values in gitbucket like 25 for Isseus/PRs and 10 for Releases. Some of those API doesn't support paging yet. It sounds difficult to implement, but using the minimum number among them worked out very well. So, I use 10 in this patch. Brief descriptions of problems and this patch are also available in go-gitea#30316. In addition, I'm not sure what kind of test cases are possible to write here. It's a test for migration, so it requires testing gitbucket server and gitea server, I guess. Please let me know if it is possible to write such test cases here. Thanks!
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 12, 2024
* giteaofficial/main: Change the default maxPerPage for gitbucket (go-gitea#30392) Fix the spacing issue in the Project view (go-gitea#30415) Add commit status summary table to reduce query from commit status table (go-gitea#30223) Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419) Check the token's owner and repository when registering a runner (go-gitea#30406) Avoid user does not exist error when detecting schedule actions when the commit author is an external user (go-gitea#30357) Update actions variables documents (go-gitea#30394) Fix author name alignment in commits table (go-gitea#30396)
silverwind
pushed a commit
that referenced
this pull request
Apr 12, 2024
Backport #30392 by @jam7 This patch improves the migration from gitbucket to gitea. The gitbucket uses it's own internal perPage value (= 25) for paging and ignore per_page arguments in the requested URL. This cause gitea to migrate only 25 issues and 25 PRs from gitbucket repository. This may not happens on old gitbucket. But recent gitbucket 4.40 or 4.38.4 has this problem. This patch change to use this internally hardcoded perPage of gitbucket as gitea's maxPerPage numer when migrating from gitbucket. There are several perPage values in gitbucket like 25 for Isseus/PRs and 10 for Releases. Some of those API doesn't support paging yet. It sounds difficult to implement, but using the minimum number among them worked out very well. So, I use 10 in this patch. Brief descriptions of problems and this patch are also available in #30316. In addition, I'm not sure what kind of test cases are possible to write here. It's a test for migration, so it requires testing gitbucket server and gitea server, I guess. Please let me know if it is possible to write such test cases here. Thanks! Co-authored-by: Kazushi (Jam) Marukawa <jam@pobox.com>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 13, 2024
* origin/main: (1540 commits)
Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461)
Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387)
Avoid losing token when updating mirror settings (go-gitea#30429)
Fix label rendering (go-gitea#30456)
Add comment for ContainsRedirectURI about the exact match (go-gitea#30457)
Update JS and PY deps, lock eslint and related plugins (go-gitea#30452)
Refactor cache and disable go-chi cache (go-gitea#30417)
Fix admin notice view-detail (go-gitea#30450)
Fix mirror error when mirror repo is empty (go-gitea#30432)
Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451)
Lock a few tool dependencies to major versions (go-gitea#30439)
Fix commit status cache which missed target_url (go-gitea#30426)
Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395)
Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430)
Limit the max line length when parsing git grep output (go-gitea#30418)
Change the default maxPerPage for gitbucket (go-gitea#30392)
Fix the spacing issue in the Project view (go-gitea#30415)
Add commit status summary table to reduce query from commit status table (go-gitea#30223)
Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419)
Check the token's owner and repository when registering a runner (go-gitea#30406)
...
|
Hi, thank you for merging. This page contains pictures I promised. This page describes how to reproduce problems too for the case. Thanks! https://github.com/jam7/gitea/wiki/How-to-reproduce-30392 |
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Apr 14, 2024
This patch improves the migration from gitbucket to gitea. The gitbucket uses it's own internal perPage value (= 25) for paging and ignore per_page arguments in the requested URL. This cause gitea to migrate only 25 issues and 25 PRs from gitbucket repository. This may not happens on old gitbucket. But recent gitbucket 4.40 or 4.38.4 has this problem. This patch change to use this internally hardcoded perPage of gitbucket as gitea's maxPerPage numer when migrating from gitbucket. There are several perPage values in gitbucket like 25 for Isseus/PRs and 10 for Releases. Some of those API doesn't support paging yet. It sounds difficult to implement, but using the minimum number among them worked out very well. So, I use 10 in this patch. Brief descriptions of problems and this patch are also available in go-gitea#30316. In addition, I'm not sure what kind of test cases are possible to write here. It's a test for migration, so it requires testing gitbucket server and gitea server, I guess. Please let me know if it is possible to write such test cases here. Thanks!
silverwind
pushed a commit
that referenced
this pull request
Apr 14, 2024
Backport #30392 This patch improves the migration from gitbucket to gitea. The gitbucket uses it's own internal perPage value (= 25) for paging and ignore per_page arguments in the requested URL. This cause gitea to migrate only 25 issues and 25 PRs from gitbucket repository. This may not happens on old gitbucket. But recent gitbucket 4.40 or 4.38.4 has this problem. This patch change to use this internally hardcoded perPage of gitbucket as gitea's maxPerPage numer when migrating from gitbucket. There are several perPage values in gitbucket like 25 for Isseus/PRs and 10 for Releases. Some of those API doesn't support paging yet. It sounds difficult to implement, but using the minimum number among them worked out very well. So, I use 10 in this patch. Brief descriptions of problems and this patch are also available in #30316. In addition, I'm not sure what kind of test cases are possible to write here. It's a test for migration, so it requires testing gitbucket server and gitea server, I guess. Please let me know if it is possible to write such test cases here. Thanks! Co-authored-by: Kazushi (Jam) Marukawa <jam@pobox.com>
wxiaoguang
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the migration from gitbucket to gitea.
The gitbucket uses it's own internal perPage value (= 25) for paging and ignore per_page arguments in the requested URL. This cause gitea to migrate only 25 issues and 25 PRs from gitbucket repository. This may not happens on old gitbucket. But recent gitbucket 4.40 or 4.38.4 has this problem.
This patch change to use this internally hardcoded perPage of gitbucket as gitea's maxPerPage numer when migrating from gitbucket. There are several perPage values in gitbucket like 25 for Isseus/PRs and 10 for Releases. Some of those API doesn't support paging yet. It sounds difficult to implement, but using the minimum number among them worked out very well. So, I use 10 in this patch.
Brief descriptions of problems and this patch are also available in #30316.
In addition, I'm not sure what kind of test cases are possible to write here. It's a test for migration, so it requires testing gitbucket server and gitea server, I guess. Please let me know if it is possible to write such test cases here. Thanks!