Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repo home UI when there is no repo description #30552

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Fix repo home UI when there is no repo description #30552

merged 5 commits into from
Apr 21, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 18, 2024 •
edited
Loading

Fix #30502 by a new approach.

image

@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 18, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Apr 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2024
@silverwind
Copy link
Member

What is the point of the .IsRepositoryAdmin condition here?

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 19, 2024 •
edited
Loading

What is the point of the .IsRepositoryAdmin condition here?

Don't show "no description" to non-admin users, the same as before, I think it's not bad.

@silverwind
Copy link
Member

What is the point of the .IsRepositoryAdmin condition here?

Don't show "no description" to non-admin users, the same as before, I think it's not bad.

But why? I don't understand the reason why the rendering of a placeholder would depend on user permission level. It makes no sense.

@wxiaoguang
Copy link
Contributor Author

What is the point of the .IsRepositoryAdmin condition here?

Don't show "no description" to non-admin users, the same as before, I think it's not bad.

But why? I don't understand the reason why the rendering of a placeholder would depend on user permission level. It makes no sense.

I think the "no description" here makes no sense to end users, and it makes the UI looks ugly. So it's not bad to hide it for non-admin users.

It is different from the "no description" in an empty issue, without that dummy message, the empty issue UI looks strange, so it is good to have it for everyone.

@silverwind
Copy link
Member

silverwind commented Apr 19, 2024 •
edited
Loading

I do agree we should always hide No description like GitHub also does, if we can make the edit button still available to users with edit permission.

@wxiaoguang
Copy link
Contributor Author

Removed the "no-description" in 8275653

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2024
@silverwind silverwind enabled auto-merge (squash) April 21, 2024 22:50
@silverwind silverwind merged commit f4a1cf7 into go-gitea:main Apr 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 21, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2024
@wxiaoguang wxiaoguang deleted the fix-repo-home-search branch April 22, 2024 00:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 22, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f607c27 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Use correct hash for "git update-index" (go-gitea#30626)
  Fix repo home UI when there is no repo description (go-gitea#30552)
  Fix dropdown text ellipsis (go-gitea#30628)
  fix(api): refactor branch and tag existence checks (go-gitea#30618)
  Add --skip-db option to dump command (go-gitea#30613)
  Fix flash on dashboard (go-gitea#30572)
  chore: use errors.New to replace fmt.Errorf with no parameters will much better (go-gitea#30621)
  Fix issue comment form and quick-submit (go-gitea#30623)
  Use maintained gziphandler (go-gitea#30592)
  [skip ci] Updated translations via Crowdin
  Fix package list performance (go-gitea#30520)
  Clarify permission "HasAccess" behavior (go-gitea#30585)
  Fix links in PyPI Simple Repository API page (go-gitea#30594)
  Use action user as the trigger user of schedules (go-gitea#30581)
  Fix commit file status parser (go-gitea#30602)
  Fix HEAD method for robots.txt (go-gitea#30603)
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into notext
453c63d 
* origin/main:
  Interpolate runs-on with variables when scheduling tasks (go-gitea#30640)
  Initial support for colorblindness-friendly themes (go-gitea#30625)
  Fix flash message for flex-container (go-gitea#30657)
  Perform Newest sort type correctly when sorting issues (go-gitea#30644)
  Fix project name wrapping, remove horizontal margin on header (go-gitea#30631)
  Add a db consistency check to remove runners that do not belong to a repository (go-gitea#30614)
  Fix wrong table name (go-gitea#30557)
  Fix compare api swagger (go-gitea#30648)
  [skip ci] Updated translations via Crowdin
  Fix queue test (go-gitea#30646)
  Enable jquery-related eslint rules that have no violations (go-gitea#30632)
  Enable more `revive` linter rules (go-gitea#30608)
  Remove obsolete CSS text classes (go-gitea#30576)
  Hide diff stats on empty PRs (go-gitea#30629)
  [skip ci] Updated licenses and gitignores
  Use correct hash for "git update-index" (go-gitea#30626)
  Fix repo home UI when there is no repo description (go-gitea#30552)
  Fix dropdown text ellipsis (go-gitea#30628)
  fix(api): refactor branch and tag existence checks (go-gitea#30618)
  Add --skip-db option to dump command (go-gitea#30613)
@yp05327
Copy link
Contributor

yp05327 commented Apr 24, 2024

image
The search code box seems strange ( no space to the filename, maybe it should be in the right side? also may need considering long file path) in file view page, maybe related to this PR?

@wxiaoguang
Copy link
Contributor Author

-> Fix code search input for different views #30678

@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Non-admin user doesn't show repo dummy description
5 participants
@wxiaoguang @silverwind @yp05327 @lunny @GiteaBot