Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle release list, fix branch dropdown #30837

Merged
merged 7 commits into from
May 13, 2024
Merged

Restyle release list, fix branch dropdown #30837

merged 7 commits into from
May 13, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 2, 2024 •
edited
Loading

Fixes #30821 and restyles the release list.

Desktop:

Screenshot 2024-05-02 at 20 46 10

Mobile:

Screenshot 2024-05-02 at 20 46 21

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label May 2, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 2, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 2, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 3, 2024
@lunny
Copy link
Member

lunny commented May 3, 2024

Sorry, I like the previous version better. I personally don't like too many frames.

@silverwind
Copy link
Member Author

Sorry, I like the previous version better. I personally don't like too many frames.

I think you will get used to it, it's pretty close to what github has now.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2024
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2024
@wxiaoguang
Copy link
Contributor

Hmm yes, could be tag-entry or tag-row maybe.

Would you like to do it in this PR or defer it? I would prefer to do it together since this change is being tested.

@silverwind
Copy link
Member Author

Yes I can do it here

@silverwind silverwind marked this pull request as draft May 3, 2024 15:27
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label May 7, 2024
@yp05327
Copy link
Contributor

yp05327 commented May 7, 2024 •
edited
Loading

I prefer the previous version too. or at least the background color should be same.

@silverwind
Copy link
Member Author

Maybe these boxes need a bit less color contrast against the page background. Would that work for you guys?

@yp05327
Copy link
Contributor

yp05327 commented May 8, 2024

Update my comment above:
For the PC view, I prefer the old design, but for the Mobile view, the new design looks good.

@pull-request-size pull-request-size bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2024
@silverwind
Copy link
Member Author

@wxiaoguang renamed tag to tag-list-row. I couldn't find any more matches for this class in JS and CSS.

As for the design, I think the pro's outweight the cons and I find the previous design without a box looking dated. Imho we should "boxify" more things like the issue list in the future.

@silverwind silverwind marked this pull request as ready for review May 13, 2024 17:54
@silverwind silverwind added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 13, 2024
@silverwind silverwind enabled auto-merge (squash) May 13, 2024 17:57
@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 13, 2024
@silverwind silverwind disabled auto-merge May 13, 2024 21:00
@silverwind silverwind merged commit ed25676 into go-gitea:main May 13, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 13, 2024
@silverwind silverwind deleted the rellist branch May 13, 2024 21:33
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request May 13, 2024
@silverwind @GiteaBot
Restyle release list, fix branch dropdown (go-gitea#30837)
c2f06e9 
Fixes go-gitea#30821 and restyles the
release list.

Desktop:

<img width="1199" alt="Screenshot 2024-05-02 at 20 46 10"
src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd">


Mobile:

<img width="443" alt="Screenshot 2024-05-02 at 20 46 21"
src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d">

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this pull request May 13, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 13, 2024
silverwind added a commit that referenced this pull request May 13, 2024
@GiteaBot @silverwind
Restyle release list, fix branch dropdown (#30837) (#30968)
c1337e7 
Backport #30837 by @silverwind

Fixes #30821 and restyles the
release list.

Desktop:

<img width="1199" alt="Screenshot 2024-05-02 at 20 46 10"
src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd">


Mobile:

<img width="443" alt="Screenshot 2024-05-02 at 20 46 21"
src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d">

Co-authored-by: silverwind <me@silverwind.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f35d360 
* giteaofficial/main:
  Protected tag is no internal server error (go-gitea#30962)
  [skip ci] Updated translations via Crowdin
  Restyle release list, fix branch dropdown (go-gitea#30837)
  fix: change npm scope registry (go-gitea#30964)
  Support using label names when changing issue labels (go-gitea#30943)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

ui bug on mobile on releases page
5 participants
@silverwind @lunny @wxiaoguang @yp05327 @GiteaBot