Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for a credentials chain for minio access #31051

Merged
merged 4 commits into from
May 27, 2024
Merged

feat: add support for a credentials chain for minio access #31051

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03bb387
feat: add support for a credentials chain for minio access
bohde May 22, 2024
86d3f62
docs: document credentials chain for minio access
bohde May 23, 2024
197612e
Merge branch 'main' into rb/minio-credentials-chain
kdumontnu May 23, 2024
1a4127f
fix: add tests for Minio credentials
bohde May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion modules/storage/minio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,34 @@ func NewMinioStorage(ctx context.Context, cfg *setting.Storage) (ObjectStorage,
return nil, fmt.Errorf("invalid minio bucket lookup type: %s", config.BucketLookUpType)
}

// By default, use the static credentials
creds := credentials.NewStaticV4(config.AccessKeyID, config.SecretAccessKey, "")

// If the Access Key ID is empty, configure a credentials chain for S3 access
if config.AccessKeyID == "" {
chain := []credentials.Provider{
// configure based upon MINIO_ prefixed environment variables
&credentials.EnvMinio{},
// configure based upon AWS_ prefixed environment variables
&credentials.EnvAWS{},
// read credentials from MINIO_SHARED_CREDENTIALS_FILE
// environment variable, or default json config files
&credentials.FileMinioClient{},
// read credentials from AWS_SHARED_CREDENTIALS_FILE
// environment variable, or default credentials file
&credentials.FileAWSCredentials{},
// read IAM role from EC2 metadata endpoint if available
&credentials.IAM{
Client: &http.Client{
Transport: http.DefaultTransport,
},
},
}
creds = credentials.NewChainCredentials(chain)
}

minioClient, err := minio.New(config.Endpoint, &minio.Options{
Creds: credentials.NewStaticV4(config.AccessKeyID, config.SecretAccessKey, ""),
Creds: creds,
Secure: config.UseSSL,
Transport: &http.Transport{TLSClientConfig: &tls.Config{InsecureSkipVerify: config.InsecureSkipVerify}},
Region: config.Location,
Expand Down