Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix border radius on hovered secondary menu #31089

Merged
merged 2 commits into from
May 27, 2024
Merged

Fix border radius on hovered secondary menu #31089

merged 2 commits into from
May 27, 2024

Conversation

silverwind
Copy link
Member

Presumably a regression from #30325, these menus were showing a border radius on hover, which is fixed with this change.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 27, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2024
@lunny lunny enabled auto-merge (squash) May 27, 2024 04:44
@lunny lunny merged commit 145baa2 into go-gitea:main May 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 27, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 27, 2024
@silverwind @GiteaBot
Fix border radius on hovered secondary menu (go-gitea#31089)
7e6db00 
Presumably a regression from
go-gitea#30325, these menus were showing a
border radius on hover, which is fixed with this change.

<img width="154" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/eafdc1c5-3cf5-48d1-86c4-21c58f92cfaf">
@GiteaBot GiteaBot mentioned this pull request May 27, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 27, 2024
lunny pushed a commit that referenced this pull request May 27, 2024
@GiteaBot @silverwind
Fix border radius on hovered secondary menu (#31089) (#31097)
0e70f73 
Backport #31089 by @silverwind

Presumably a regression from
#30325, these menus were showing a
border radius on hover, which is fixed with this change.

<img width="154" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/eafdc1c5-3cf5-48d1-86c4-21c58f92cfaf">

Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HEREYUA HEREYUA HEREYUA approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @HEREYUA @GiteaBot