Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop IDOrderDesc for listing Actions task and always order by id DESC #31150

Merged
merged 5 commits into from
May 31, 2024
Merged

Drop IDOrderDesc for listing Actions task and always order by id DESC #31150

merged 5 commits into from
May 31, 2024

Conversation

wolfogre
Copy link
Member

Close #31066

Just follow what FindRunOptions and FindScheduleOptions do.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 29, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 29, 2024
@wolfogre wolfogre mentioned this pull request May 29, 2024
Closed
@wolfogre wolfogre added the type/enhancement An improvement of existing functionality label May 29, 2024
@wolfogre wolfogre changed the title Drop IDOrderDesc for listing Actions task and always order byid DESC Drop IDOrderDesc for listing Actions task and always order by id DESC May 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2024
@lunny lunny added this to the 1.23.0 milestone May 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2024
@lunny lunny enabled auto-merge (squash) May 31, 2024 01:51
@lunny lunny merged commit 572fa55 into go-gitea:main May 31, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
12e3fc3 
* giteaofficial/main:
  Drop `IDOrderDesc` for listing Actions task and always order by `id DESC` (go-gitea#31150)
  Fix branch order (go-gitea#31174)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

API ListActionTasks is not sorted chronologically
4 participants
@wolfogre @lunny @silverwind @GiteaBot