Skip to content

Swap word order in Comment and Close (#31148) #31165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverwind merged 2 commits into from
May 30, 2024
Merged

Swap word order in Comment and Close (#31148) #31165

silverwind merged 2 commits into from
May 30, 2024

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented May 29, 2024

Backport #31148 by @techknowlogick

Reduce accident closing of tickets only to re-open them right away. This aligns the text on these buttons with what GitHub has.

Commit is authored by @LazyDodo, and was committed to the Blender fork by @brechtvl

Background details: https://projects.blender.org/infrastructure/gitea-custom/pulls/7

@techknowlogick @LazyDodo @GiteaBot
Swap word order in Comment and Close (go-gitea#31148)
999abca 
Reduce accident closing of tickets only to re-open them right away. This
aligns the text on these buttons with what GitHub has.

Commit is authored by @LazyDodo, and was committed to the Blender fork
by @brechtvl

Background details:
https://projects.blender.org/infrastructure/gitea-custom/pulls/7

Co-authored-by: Ray Molenkamp <github@lazydodo.com>
@GiteaBot GiteaBot added modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality labels May 29, 2024
@GiteaBot GiteaBot added this to the 1.22.1 milestone May 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2024
@GiteaBot GiteaBot requested review from lunny and silverwind May 29, 2024 15:54
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2024
@silverwind silverwind enabled auto-merge (squash) May 30, 2024 00:38
@silverwind silverwind merged commit f0d55e4 into go-gitea:release/v1.22 May 30, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

@techknowlogick techknowlogick

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.22.1

Development

Successfully merging this pull request may close these issues.

4 participants

@GiteaBot @lunny @silverwind @techknowlogick