Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqlite-viewer and using database client #31223

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jun 2, 2024

sqlite-viewer can not edit sqlite.
database client can connect to almost all common databases, which is very useful I think. Of cause, it can edit sqlite.
https://marketplace.visualstudio.com/items?itemName=cweijan.vscode-database-client2

And for using sqlite, sqlite3 is required. So also added a new feature:
https://github.com/warrenbuckley/codespace-features
found from: https://containers.dev/features

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 2, 2024
@yp05327 yp05327 changed the title Remove sqlite-viewer and using database client Remove sqlite-viewer and using database client in dev container Jun 2, 2024
@yp05327 yp05327 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 2, 2024
@silverwind
Copy link
Member

Also update .gitpod.yml?

@yp05327 yp05327 changed the title Remove sqlite-viewer and using database client in dev container Remove sqlite-viewer and using database client Jun 3, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2024
@lunny lunny enabled auto-merge (squash) June 3, 2024 10:40
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 3, 2024
@lunny lunny merged commit fc641b3 into go-gitea:main Jun 3, 2024
24 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 3, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 3, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 4, 2024
* giteaofficial/main:
  Add option for mailer to override mail headers (go-gitea#27860)
  Move custom `tw-` helpers to tailwind plugin (go-gitea#31184)
  Remove unnecessary inline style for tab-size (go-gitea#31224)
  Document possible action types for the user activity feed API (go-gitea#31196)
  Remove sqlite-viewer and using database client (go-gitea#31223)
  Update golangci-lint to v1.59.0 (go-gitea#31221)
@yp05327 yp05327 deleted the update-devcontainer-extention-for-db branch July 29, 2024 04:10
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants