Fix alert blocks not following GitHub's behaviour with backslashes #31231
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
Previously, these blocks would only get rendered if the markdown was `[!TYPE]`. Now they also render with `\[!TYPE\]`. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
yardenshoham
force-pushed
the
issues/31214
branch
from
7be636b to
f2951b1
Compare
|
Hmm… I'm torn on this one. Should we cave to a bug in the dominant player? |
| attentionParagraph := newAttentionParagraph(v, attentionType, g) | ||
| v.InsertBefore(v, firstChild, attentionParagraph) | ||
| if firstChild.ChildCount() == 0 { | ||
| v.RemoveChild(v, firstChild) |
There was a problem hiding this comment.
popAttentionTypeFromParagraph / popAttentionTypeFromMathBlock should handle the removal correctly, instead of removing the children here.
| if firstParagraph.ChildCount() < 3 { | ||
| return ast.WalkContinue, nil | ||
| // make sure it's a !TYPE | ||
| if innerText[0] != '!' { |
There was a problem hiding this comment.
strings.HasPrefix to avoid panic if string is empty
| if paragraph, ok := firstChild.(*ast.Paragraph); ok { | ||
| attentionType = popAttentionTypeFromParagraph(g, paragraph, reader) | ||
| } else { | ||
| mathBlock, ok := firstChild.(*math.Block) |
There was a problem hiding this comment.
Maybe in the future we should use an "Extension" like "math" , instead of using "transform", then no need to play the type-casting trick with "math.Block" (just an idea, not a change suggestion 😁 )
|
@delvh convinced me |
|
But according to the reporter:
So I would suppose the |
|
-> Make blockquote attention recognize more syntaxes #31240 |
Previously, these blocks would only get rendered if the markdown was
[!TYPE]. Now they also render with\[!TYPE\].Before
After