Fix and clean up ConfirmModal
#31283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
reviewed
Jun 7, 2024
wxiaoguang
reviewed
Jun 7, 2024
|
Changed function signature to make it more clear: confirmModal(content, {confirmButtonColor = 'primary'} = {})Content is required, and |
silverwind
commented
Jun 7, 2024
|
BTW i think some of these |
wxiaoguang
reviewed
Jun 7, 2024
wxiaoguang
approved these changes
Jun 7, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jun 7, 2024
GiteaBot
added
lgtm/done
Co-authored-by: delvh <dev.lh@web.de>
silverwind
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 7, 2024
Bug: orange button color was removed in go-gitea#30475, replaced with red Bug: translation text was not html-escaped Refactor: Replaced as much jQuery as possible, added useful `createElementFromHTML` Refactor: Remove colors checks that don't exist on `.link-action` <img width="381" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/5900bf6a-8a86-4a86-b368-0559cbfea66e"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>
GiteaBot
added
backport/done
silverwind
added a commit
that referenced
this pull request
Jun 7, 2024
Backport #31283 by @silverwind Bug: orange button color was removed in #30475, replaced with red Bug: translation text was not html-escaped Refactor: Replaced as much jQuery as possible, added useful `createElementFromHTML` Refactor: Remove colors checks that don't exist on `.link-action` <img width="381" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/5900bf6a-8a86-4a86-b368-0559cbfea66e"> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 7, 2024
* giteaofficial/main: Fix and clean up `ConfirmModal` (go-gitea#31283) Enable poetry non-package mode (go-gitea#31282) fixed the dropdown menu for the top New button to expand to the left (go-gitea#31273) Optimize repo-list layout to enhance visual experience (go-gitea#31272) Allow including `Reviewed-on`/`Reviewed-by` lines for custom merge messages (go-gitea#31211) Add `MAX_ROWS` option for CSV rendering (go-gitea#30268) Update `golang.org/x/net` (go-gitea#31260) Add replacement module for `mholt/archiver` (go-gitea#31267) Fix Activity Page Contributors dropdown (go-gitea#31264)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jul 29, 2024
…tea#31684) Tested it, path segment creation works just like before. --- Conflict resolution: trivial, also ported code from go-gitea/gitea#31283
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: orange button color was removed in #30475, replaced with red
Bug: translation text was not html-escaped
Refactor: Replaced as much jQuery as possible, added useful
createElementFromHTMLRefactor: Remove colors checks that don't exist on
.link-action