Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move registerActionsCleanup to initActionsTasks #31721

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Move registerActionsCleanup to initActionsTasks #31721

merged 3 commits into from
Jul 30, 2024

Conversation

wolfogre
Copy link
Member

There's already initActionsTasks; it will avoid additional check for if Actions enabled to move registerActionsCleanup into it.

And we don't really need OlderThanConfig.

@wolfogre wolfogre added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/gitea-actions related to the actions of Gitea labels Jul 29, 2024
@wolfogre wolfogre added this to the 1.23.0 milestone Jul 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 29, 2024
@wolfogre
Copy link
Member Author

I noticed this when trying to implement Actions log clearing.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 30, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2024
@wolfogre wolfogre merged commit f989f46 into go-gitea:main Jul 30, 2024
26 checks passed
@wolfogre wolfogre deleted the bugfix/cleanup_actions branch July 30, 2024 02:27
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 30, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f387831 
* giteaofficial/main:
  Improve names of cron jobs for Actions (go-gitea#31736)
  [skip ci] Updated translations via Crowdin
  Fix the display of project type for deleted projects (go-gitea#31732)
  Fix Null Pointer error for CommitStatusesHideActionsURL (go-gitea#31731)
  Move `registerActionsCleanup` to `initActionsTasks` (go-gitea#31721)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/gitea-actions related to the actions of Gitea type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfogre @lunny @a1012112796 @GiteaBot