Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic of ssh public key page after deletion of auth source #31829

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix panic of ssh public key page after deletion of auth source #31829

merged 2 commits into from
Aug 15, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 14, 2024

Fix #31730

This PR rewrote the function PublicKeysAreExternallyManaged with a simple test. The new function removed the loop to make it more readable.

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Aug 14, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 15, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 15, 2024
@lunny lunny merged commit b491b21 into go-gitea:main Aug 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 15, 2024
@lunny lunny deleted the lunny/fix_public_key_delete branch August 15, 2024 15:59
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Aug 15, 2024
@lunny @GiteaBot
Fix panic of ssh public key page after deletion of auth source (go-gi…
c5dca16 
…tea#31829)

Fix go-gitea#31730 

This PR rewrote the function `PublicKeysAreExternallyManaged` with a
simple test. The new function removed the loop to make it more readable.
@GiteaBot GiteaBot mentioned this pull request Aug 15, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 15, 2024
lunny added a commit that referenced this pull request Aug 15, 2024
@GiteaBot @lunny
Fix panic of ssh public key page after deletion of auth source (#31829)…
5fa90ad 
… (#31836)

Backport #31829 by @lunny

Fix #31730 

This PR rewrote the function `PublicKeysAreExternallyManaged` with a
simple test. The new function removed the loop to make it more readable.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cd76c70 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add missing repository type filter parameters to pager  (go-gitea#31832)
  Fix panic of ssh public key page after deletion of auth source (go-gitea#31829)
  [skip ci] Updated translations via Crowdin
  render plain text file if the LFS object doesn't exist (go-gitea#31812)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Index out of range exception for the SSH Public Key page after deletion of auth source
4 participants
@lunny @lafriks @wolfogre @GiteaBot