Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing repository type filter parameters to pager (#31832) #31837

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add missing repository type filter parameters to pager (#31832) #31837

merged 2 commits into from
Aug 16, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #31832 by @yp05327

Fix #31807

ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will be 0 or 1
But in pager it will be true or false.
So do we have boolToInt function?

@yp05327 @GiteaBot
Add missing repository type filter parameters to pager (go-gitea#31832)
cbe44ff 
Fix go-gitea#31807

ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will
be `0` or `1`
But in pager it will be `true` or `false`.
So do we have `boolToInt` function?
@GiteaBot GiteaBot added the modifies/go Pull requests that update Go code label Aug 15, 2024
@GiteaBot GiteaBot requested review from lunny and wolfogre August 15, 2024 16:34
@GiteaBot GiteaBot added this to the 1.22.2 milestone Aug 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 15, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 16, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 16, 2024
@wolfogre wolfogre merged commit 771fb45 into go-gitea:release/v1.22 Aug 16, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 16, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

Assignees

@yp05327 yp05327

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @wolfogre @yp05327