Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lock icon position and add additional tooltips to branch list page #31839

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

william-allspice
Copy link
Contributor

@william-allspice william-allspice commented Aug 15, 2024

This Pull Request adds missing tool tips for the protected, copy, and rss icons on the branch list page. It also moved protected icon position after the branch name.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 15, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Aug 15, 2024
@lunny
Copy link
Member

lunny commented Aug 16, 2024

Can you post some screenshots?

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Aug 16, 2024
@lunny lunny added this to the 1.23.0 milestone Aug 16, 2024
templates/repo/branch/list.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 16, 2024
@delvh delvh changed the title Enhancement: Add additional tooltips to branch list page Add additional tooltips to branch list page Aug 16, 2024
@delvh delvh added the type/enhancement An improvement of existing functionality label Aug 16, 2024
Co-authored-by: delvh <dev.lh@web.de>
@lunny
Copy link
Member

lunny commented Aug 17, 2024

Non default branch's rss button's tooltips are missed.

@lunny
Copy link
Member

lunny commented Aug 20, 2024

Non default branch's rss button's tooltips are missed.

Could you add those class?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2024
@lunny lunny changed the title Add additional tooltips to branch list page Move lock icon position and add additional tooltips to branch list page Aug 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
@lunny lunny enabled auto-merge (squash) August 21, 2024 05:11
@lunny lunny merged commit 40036b6 into go-gitea:main Aug 21, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 24, 2024
* giteaofficial/main:
  Bump relative-time-element to v4.4.3 (go-gitea#31910)
  [skip ci] Updated translations via Crowdin
  Use correct function name (go-gitea#31887)
  Move lock icon position and add additional tooltips to branch list page (go-gitea#31839)
  Don't return 500 if mirror url contains special chars (go-gitea#31859)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants